Commit 86287543 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: atlantic: fix missing | operator when assigning rec->llc

rec->llc is currently being assigned twice, once with the lower 8 bits
from packed_record[8] and then re-assigned afterwards with data from
packed_record[9].  This looks like a type, I believe the second assignment
should be using the |= operator rather than a direct assignment.

Addresses-Coverity: ("Unused value")
Fixes: b8f8a0b7 ("net: atlantic: MACSec ingress offload HW bindings")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarIgor Russkikh <irusskikh@marell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2abb5792
...@@ -491,7 +491,7 @@ get_ingress_preclass_record(struct aq_hw_s *hw, ...@@ -491,7 +491,7 @@ get_ingress_preclass_record(struct aq_hw_s *hw,
rec->snap[1] = packed_record[8] & 0xFF; rec->snap[1] = packed_record[8] & 0xFF;
rec->llc = (packed_record[8] >> 8) & 0xFF; rec->llc = (packed_record[8] >> 8) & 0xFF;
rec->llc = packed_record[9] << 8; rec->llc |= packed_record[9] << 8;
rec->mac_sa[0] = packed_record[10]; rec->mac_sa[0] = packed_record[10];
rec->mac_sa[0] |= packed_record[11] << 16; rec->mac_sa[0] |= packed_record[11] << 16;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment