Commit 86a565e6 authored by Marc Carino's avatar Marc Carino Committed by Tejun Heo

libata: bugfix: Remove __le32 in ata_tf_to_fis()

The endianness attribute on the 'aux' local variable is wrong, and can
lead to wrong endianness on big-endian machines,
Signed-off-by: default avatarMarc Carino <marc.ceeeee@gmail.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 03f7b802
...@@ -546,8 +546,6 @@ int atapi_cmd_type(u8 opcode) ...@@ -546,8 +546,6 @@ int atapi_cmd_type(u8 opcode)
*/ */
void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis) void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis)
{ {
const __le32 aux = cpu_to_le32(tf->auxiliary);
fis[0] = 0x27; /* Register - Host to Device FIS */ fis[0] = 0x27; /* Register - Host to Device FIS */
fis[1] = pmp & 0xf; /* Port multiplier number*/ fis[1] = pmp & 0xf; /* Port multiplier number*/
if (is_cmd) if (is_cmd)
...@@ -571,10 +569,10 @@ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis) ...@@ -571,10 +569,10 @@ void ata_tf_to_fis(const struct ata_taskfile *tf, u8 pmp, int is_cmd, u8 *fis)
fis[14] = 0; fis[14] = 0;
fis[15] = tf->ctl; fis[15] = tf->ctl;
fis[16] = aux & 0xff; fis[16] = tf->auxiliary & 0xff;
fis[17] = (aux >> 8) & 0xff; fis[17] = (tf->auxiliary >> 8) & 0xff;
fis[18] = (aux >> 16) & 0xff; fis[18] = (tf->auxiliary >> 16) & 0xff;
fis[19] = (aux >> 24) & 0xff; fis[19] = (tf->auxiliary >> 24) & 0xff;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment