Commit 8826b3d3 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Linus Torvalds

[PATCH] ext2/ext3 ACLs: remove the number of acl entries limit

This patch removes the arbitrary limit of 32 acl entries on ext[23] when
writing acls.  A patch that removes the same check when reding acls is in
BK since 12 March 2004, so all kernels since then are already able to read
large acls.  I think that ten+ months are enough so that we can now also
remove the write limit.

This is the read-limit patch:
http://linux.bkbits.net:8080/linux-2.6/cset%404051e2863UsuQEgAQShmimgBooAXkg?nav=index.html

Even without this patch the xattr block could already contain less space
than needed for the acl, because other attributes might already use up
almost all space.  So this patch does not introduce additional error
conditions.  We have been shipping with this patch the last year (almost).
Signed-off-by: default avatarAndreas Gruenbacher <agruen@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent ce9be3ce
......@@ -255,8 +255,6 @@ ext2_set_acl(struct inode *inode, int type, struct posix_acl *acl)
return -EINVAL;
}
if (acl) {
if (acl->a_count > EXT2_ACL_MAX_ENTRIES)
return -EINVAL;
value = ext2_acl_to_disk(acl, &size);
if (IS_ERR(value))
return (int)PTR_ERR(value);
......
......@@ -7,7 +7,6 @@
#include <linux/xattr_acl.h>
#define EXT2_ACL_VERSION 0x0001
#define EXT2_ACL_MAX_ENTRIES 32
typedef struct {
__le16 e_tag;
......
......@@ -259,8 +259,6 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type,
return -EINVAL;
}
if (acl) {
if (acl->a_count > EXT3_ACL_MAX_ENTRIES)
return -EINVAL;
value = ext3_acl_to_disk(acl, &size);
if (IS_ERR(value))
return (int)PTR_ERR(value);
......
......@@ -7,7 +7,6 @@
#include <linux/xattr_acl.h>
#define EXT3_ACL_VERSION 0x0001
#define EXT3_ACL_MAX_ENTRIES 32
typedef struct {
__le16 e_tag;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment