Commit 8c5fcd24 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds

checkpatch: more comprehensive split strings warning

The current checkpatch test for split strings does not find several
cases that should be found.

For instance:

 		/* Else poor success; go back to mode in "active" table */
 		} else {
 			IWL_DEBUG_RATE(mvm,
-				       "LQ: GOING BACK TO THE OLD TABLE suc=%d cur-tpt=%d old-tpt=%d\n",
+				       "GOING BACK TO THE OLD TABLE: SR %d "
+				       "cur-tpt %d old-tpt %d\n",
 				       window->success_ratio,
 				       window->average_tpt,
 				      lq_sta->last_tpt);

does not currently emit a warning.

Improve the test to find these cases.

Add more exceptions to reduce false positives for assembly and octal/hex
string constants.
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cf074402
...@@ -2049,16 +2049,12 @@ sub process { ...@@ -2049,16 +2049,12 @@ sub process {
} }
# Check for user-visible strings broken across lines, which breaks the ability # Check for user-visible strings broken across lines, which breaks the ability
# to grep for the string. Limited to strings used as parameters (those # to grep for the string. Make exceptions when the previous string ends in a
# following an open parenthesis), which almost completely eliminates false # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
# positives, as well as warning only once per parameter rather than once per # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
# line of the string. Make an exception when the previous string ends in a
# newline (multiple lines in one string constant) or \n\t (common in inline
# assembly to indent the instruction on the following line).
if ($line =~ /^\+\s*"/ && if ($line =~ /^\+\s*"/ &&
$prevline =~ /"\s*$/ && $prevline =~ /"\s*$/ &&
$prevline =~ /\(/ && $prevrawline !~ /(?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$/) {
$prevrawline !~ /\\n(?:\\t)*"\s*$/) {
WARN("SPLIT_STRING", WARN("SPLIT_STRING",
"quoted string split across lines\n" . $hereprev); "quoted string split across lines\n" . $hereprev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment