Commit 8c6c2fe2 authored by Ville Syrjälä's avatar Ville Syrjälä

drm: WARN when trying to add enum value > 63 to a bitmask property

Enum values >63 with a bitmask property is a programmer error. WARN
when someone is attempting this.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180306164849.2862-3-ville.syrjala@linux.intel.comReviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 1371f260
...@@ -386,8 +386,8 @@ int drm_property_add_enum(struct drm_property *property, int index, ...@@ -386,8 +386,8 @@ int drm_property_add_enum(struct drm_property *property, int index,
* Bitmask enum properties have the additional constraint of values * Bitmask enum properties have the additional constraint of values
* from 0 to 63 * from 0 to 63
*/ */
if (drm_property_type_is(property, DRM_MODE_PROP_BITMASK) && if (WARN_ON(drm_property_type_is(property, DRM_MODE_PROP_BITMASK) &&
(value > 63)) value > 63))
return -EINVAL; return -EINVAL;
list_for_each_entry(prop_enum, &property->enum_list, head) { list_for_each_entry(prop_enum, &property->enum_list, head) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment