Commit 8e5975c8 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Lachlan McIlroy

[XFS] optimize xfs_ichgtime

Port a little optmization from file_update_time to xfs_ichgtime, and only
update the timestamp and mark the inode dirty if the timestamp actually
changes in the timer tick resultion supported by the running kernel.

SGI-PV: 981498

SGI-Modid: xfs-linux-melb:xfs-kern:31827a
Signed-off-by: default avatarChristoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarLachlan McIlroy <lachlan@sgi.com>
parent dff35fd4
...@@ -97,17 +97,23 @@ xfs_ichgtime( ...@@ -97,17 +97,23 @@ xfs_ichgtime(
{ {
struct inode *inode = VFS_I(ip); struct inode *inode = VFS_I(ip);
timespec_t tv; timespec_t tv;
int sync_it = 0;
nanotime(&tv); tv = current_fs_time(inode->i_sb);
if (flags & XFS_ICHGTIME_MOD) {
if ((flags & XFS_ICHGTIME_MOD) &&
!timespec_equal(&inode->i_mtime, &tv)) {
inode->i_mtime = tv; inode->i_mtime = tv;
ip->i_d.di_mtime.t_sec = (__int32_t)tv.tv_sec; ip->i_d.di_mtime.t_sec = (__int32_t)tv.tv_sec;
ip->i_d.di_mtime.t_nsec = (__int32_t)tv.tv_nsec; ip->i_d.di_mtime.t_nsec = (__int32_t)tv.tv_nsec;
sync_it = 1;
} }
if (flags & XFS_ICHGTIME_CHG) { if ((flags & XFS_ICHGTIME_CHG) &&
!timespec_equal(&inode->i_ctime, &tv)) {
inode->i_ctime = tv; inode->i_ctime = tv;
ip->i_d.di_ctime.t_sec = (__int32_t)tv.tv_sec; ip->i_d.di_ctime.t_sec = (__int32_t)tv.tv_sec;
ip->i_d.di_ctime.t_nsec = (__int32_t)tv.tv_nsec; ip->i_d.di_ctime.t_nsec = (__int32_t)tv.tv_nsec;
sync_it = 1;
} }
/* /*
...@@ -119,10 +125,11 @@ xfs_ichgtime( ...@@ -119,10 +125,11 @@ xfs_ichgtime(
* ensure that the compiler does not reorder the update * ensure that the compiler does not reorder the update
* of i_update_core above the timestamp updates above. * of i_update_core above the timestamp updates above.
*/ */
if (sync_it) {
SYNCHRONIZE(); SYNCHRONIZE();
ip->i_update_core = 1; ip->i_update_core = 1;
if (!(inode->i_state & I_NEW))
mark_inode_dirty_sync(inode); mark_inode_dirty_sync(inode);
}
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment