Commit 90140116 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai

ALSA: bebob: Fix a missing to unlock mutex in error handling case

In error handling case, special_clk_ctl_put() returns without unlock_mutex(),
therefore the mutex is still locked. This commit moves mutex_lock() after
the error handling case.

This commit is my solution for this post.

[PATCH -next] ALSA: bebob: Fix missing unlock on error in special_clk_ctl_put()
https://lkml.org/lkml/2014/7/20/12Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 4da63c6f
...@@ -379,12 +379,12 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl, ...@@ -379,12 +379,12 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl,
struct special_params *params = bebob->maudio_special_quirk; struct special_params *params = bebob->maudio_special_quirk;
int err, id; int err, id;
mutex_lock(&bebob->mutex);
id = uval->value.enumerated.item[0]; id = uval->value.enumerated.item[0];
if (id >= ARRAY_SIZE(special_clk_labels)) if (id >= ARRAY_SIZE(special_clk_labels))
return 0; return 0;
mutex_lock(&bebob->mutex);
err = avc_maudio_set_special_clk(bebob, id, err = avc_maudio_set_special_clk(bebob, id,
params->dig_in_fmt, params->dig_in_fmt,
params->dig_out_fmt, params->dig_out_fmt,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment