Commit 909baf00 authored by Andres Salomon's avatar Andres Salomon Committed by Linus Torvalds

amba-clcd: fix cmap memory leaks

- fix cmap leak in removal path

- fix cmap leak when register_framebuffer fails
Signed-off-by: default avatarAndres Salomon <dilinger@debian.org>
Acked-by: default avatarKrzysztof Helt <krzysztof.h1@wp.pl>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent e98d9b40
...@@ -408,7 +408,9 @@ static int clcdfb_register(struct clcd_fb *fb) ...@@ -408,7 +408,9 @@ static int clcdfb_register(struct clcd_fb *fb)
/* /*
* Allocate colourmap. * Allocate colourmap.
*/ */
fb_alloc_cmap(&fb->fb.cmap, 256, 0); ret = fb_alloc_cmap(&fb->fb.cmap, 256, 0);
if (ret)
goto unmap;
/* /*
* Ensure interrupts are disabled. * Ensure interrupts are disabled.
...@@ -426,6 +428,8 @@ static int clcdfb_register(struct clcd_fb *fb) ...@@ -426,6 +428,8 @@ static int clcdfb_register(struct clcd_fb *fb)
printk(KERN_ERR "CLCD: cannot register framebuffer (%d)\n", ret); printk(KERN_ERR "CLCD: cannot register framebuffer (%d)\n", ret);
fb_dealloc_cmap(&fb->fb.cmap);
unmap:
iounmap(fb->regs); iounmap(fb->regs);
free_clk: free_clk:
clk_put(fb->clk); clk_put(fb->clk);
...@@ -485,6 +489,8 @@ static int clcdfb_remove(struct amba_device *dev) ...@@ -485,6 +489,8 @@ static int clcdfb_remove(struct amba_device *dev)
clcdfb_disable(fb); clcdfb_disable(fb);
unregister_framebuffer(&fb->fb); unregister_framebuffer(&fb->fb);
if (fb->fb.cmap.len)
fb_dealloc_cmap(&fb->fb.cmap);
iounmap(fb->regs); iounmap(fb->regs);
clk_put(fb->clk); clk_put(fb->clk);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment