Commit 910570b5 authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville

mac80211: off by one in mcs mask handling

"ridx" is used as an index into the mcs_mask[] array which has
IEEE80211_HT_MCS_MASK_LEN elements.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent d486a5b4
...@@ -324,7 +324,7 @@ static bool rate_idx_match_mcs_mask(struct ieee80211_tx_rate *rate, ...@@ -324,7 +324,7 @@ static bool rate_idx_match_mcs_mask(struct ieee80211_tx_rate *rate,
rbit = rate->idx % 8; rbit = rate->idx % 8;
/* sanity check */ /* sanity check */
if (ridx < 0 || ridx > IEEE80211_HT_MCS_MASK_LEN) if (ridx < 0 || ridx >= IEEE80211_HT_MCS_MASK_LEN)
return false; return false;
/* See whether the selected rate or anything below it is allowed. */ /* See whether the selected rate or anything below it is allowed. */
......
...@@ -5410,7 +5410,7 @@ static bool ht_rateset_to_mask(struct ieee80211_supported_band *sband, ...@@ -5410,7 +5410,7 @@ static bool ht_rateset_to_mask(struct ieee80211_supported_band *sband,
rbit = BIT(rates[i] % 8); rbit = BIT(rates[i] % 8);
/* check validity */ /* check validity */
if ((ridx < 0) || (ridx > IEEE80211_HT_MCS_MASK_LEN)) if ((ridx < 0) || (ridx >= IEEE80211_HT_MCS_MASK_LEN))
return false; return false;
/* check availability */ /* check availability */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment