Commit 934a5fc9 authored by Tom Rini's avatar Tom Rini Committed by Linus Torvalds

[PATCH] ppc32: CPM2 bug

Rune has determined that:
res6 should be 94 bytes long.

However... It does work @ 92 bytes because the compiler alligns the next
struct (pci_cpm2_t) on a int boundary anyways (no packing specified fo
the structs)

I tested it with a module that pronted out the address of the PCI struct
that follows the sit_cpm2_t struct.

Imap = 0xF0000000
With res6[92]
im-pci is @  0xf0010430

With res6[94]
im-pci is @  0xf0010430

So we're saved by the compiler.

Here's the patch
Signed-off-by: default avatarRune Torgersen <runet@innovsys.com>
Signed-off-by: default avatarTom Rini <trini@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2252004f
...@@ -133,7 +133,7 @@ typedef struct sys_int_timers { ...@@ -133,7 +133,7 @@ typedef struct sys_int_timers {
u8 res5[2]; u8 res5[2];
u32 sit_pitc; u32 sit_pitc;
u32 sit_pitr; u32 sit_pitr;
u8 res6[92]; u8 res6[94];
u8 res7[390]; u8 res7[390];
} sit_cpm2_t; } sit_cpm2_t;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment