Commit 96ca7c41 authored by Michael Tretter's avatar Michael Tretter Committed by Mauro Carvalho Chehab

media: tvp5150: initialize subdev before parsing device tree

There are several debug prints in the tvp5150_parse_dt() function, which
do not print the prefix, because the v4l2_subdev is not initialized, yet.

Initialize the v4l2_subdev before parsing the device tree to fix the
debug messages.
Signed-off-by: default avatarMichael Tretter <m.tretter@pengutronix.de>
Signed-off-by: default avatarMarco Felsch <m.felsch@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 46fe6e7d
...@@ -2009,6 +2009,9 @@ static int tvp5150_probe(struct i2c_client *c) ...@@ -2009,6 +2009,9 @@ static int tvp5150_probe(struct i2c_client *c)
core->regmap = map; core->regmap = map;
sd = &core->sd; sd = &core->sd;
v4l2_i2c_subdev_init(sd, c, &tvp5150_ops);
sd->internal_ops = &tvp5150_internal_ops;
sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
if (IS_ENABLED(CONFIG_OF) && np) { if (IS_ENABLED(CONFIG_OF) && np) {
res = tvp5150_parse_dt(core, np); res = tvp5150_parse_dt(core, np);
...@@ -2021,10 +2024,6 @@ static int tvp5150_probe(struct i2c_client *c) ...@@ -2021,10 +2024,6 @@ static int tvp5150_probe(struct i2c_client *c)
core->mbus_type = V4L2_MBUS_BT656; core->mbus_type = V4L2_MBUS_BT656;
} }
v4l2_i2c_subdev_init(sd, c, &tvp5150_ops);
sd->internal_ops = &tvp5150_internal_ops;
sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
res = tvp5150_mc_init(core); res = tvp5150_mc_init(core);
if (res) if (res)
return res; return res;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment