Commit 97193601 authored by Grygorii Strashko's avatar Grygorii Strashko Committed by David S. Miller

net: ethernet: ti: ale: fix port check in cpsw_ale_control_set/get

ALE ports number includes the Host port and ext Ports, and
ALE ports numbering starts from 0, so correct corresponding port
checks in cpsw_ale_control_set/get().
Signed-off-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1971ab58
...@@ -723,7 +723,7 @@ int cpsw_ale_control_set(struct cpsw_ale *ale, int port, int control, ...@@ -723,7 +723,7 @@ int cpsw_ale_control_set(struct cpsw_ale *ale, int port, int control,
if (info->port_offset == 0 && info->port_shift == 0) if (info->port_offset == 0 && info->port_shift == 0)
port = 0; /* global, port is a dont care */ port = 0; /* global, port is a dont care */
if (port < 0 || port > ale->params.ale_ports) if (port < 0 || port >= ale->params.ale_ports)
return -EINVAL; return -EINVAL;
mask = BITMASK(info->bits); mask = BITMASK(info->bits);
...@@ -754,7 +754,7 @@ int cpsw_ale_control_get(struct cpsw_ale *ale, int port, int control) ...@@ -754,7 +754,7 @@ int cpsw_ale_control_get(struct cpsw_ale *ale, int port, int control)
if (info->port_offset == 0 && info->port_shift == 0) if (info->port_offset == 0 && info->port_shift == 0)
port = 0; /* global, port is a dont care */ port = 0; /* global, port is a dont care */
if (port < 0 || port > ale->params.ale_ports) if (port < 0 || port >= ale->params.ale_ports)
return -EINVAL; return -EINVAL;
offset = info->offset + (port * info->port_offset); offset = info->offset + (port * info->port_offset);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment