Commit 97649292 authored by Robin Murphy's avatar Robin Murphy Committed by Will Deacon

iommu/arm-smmu: Update impl quirks comment

The comment about implementation and integration quirks being
mutually-exclusive is out of date, and in fact the code is already
structured for the case it anticipates, so document that properly.
Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/1e742177e084621f3454fbaf768325a6c215656a.1592994291.git.robin.murphy@arm.comSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent ecd7274f
...@@ -153,10 +153,9 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu) ...@@ -153,10 +153,9 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu)
const struct device_node *np = smmu->dev->of_node; const struct device_node *np = smmu->dev->of_node;
/* /*
* We will inevitably have to combine model-specific implementation * Set the impl for model-specific implementation quirks first,
* quirks with platform-specific integration quirks, but everything * such that platform integration quirks can pick it up and
* we currently support happens to work out as straightforward * inherit from it if necessary.
* mutually-exclusive assignments.
*/ */
switch (smmu->model) { switch (smmu->model) {
case ARM_MMU500: case ARM_MMU500:
...@@ -168,6 +167,7 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu) ...@@ -168,6 +167,7 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu)
break; break;
} }
/* This is implicitly MMU-400 */
if (of_property_read_bool(np, "calxeda,smmu-secure-config-access")) if (of_property_read_bool(np, "calxeda,smmu-secure-config-access"))
smmu->impl = &calxeda_impl; smmu->impl = &calxeda_impl;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment