Commit 9c236753 authored by Damien Lespiau's avatar Damien Lespiau Committed by Daniel Vetter

drm/i915/skl: Use a more idomatic early return

We can coalesce the WARN() condition with the WARN() itself and, as we
are returning early, we can de-intent the rest of the function.
Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 318bd821
...@@ -1193,11 +1193,10 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, ...@@ -1193,11 +1193,10 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */,
} }
} }
if (min_dco_index > 2) { if (WARN(min_dco_index > 2,
WARN(1, "No valid parameters found for pixel clock: %dHz\n", "No valid parameters found for pixel clock: %dHz\n", clock))
clock);
return false; return false;
} else {
wrpll_params->central_freq = dco_central_freq[min_dco_index]; wrpll_params->central_freq = dco_central_freq[min_dco_index];
switch (dco_central_freq[min_dco_index]) { switch (dco_central_freq[min_dco_index]) {
...@@ -1262,8 +1261,6 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, ...@@ -1262,8 +1261,6 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */,
div_u64(((div_u64(dco_freq, 24) - div_u64(((div_u64(dco_freq, 24) -
wrpll_params->dco_integer * MHz(1)) * 0x8000), MHz(1)); wrpll_params->dco_integer * MHz(1)) * 0x8000), MHz(1));
}
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment