Commit 9c5f9c28 authored by Atsushi Nemoto's avatar Atsushi Nemoto Committed by David S. Miller

isa-skelton: Remove a wrong netif_wake_queue() call

The netif_wake_queue() is called correctly (i.e. only on !txfull
condition) from net_tx().  So Unconditional call to the
netif_wake_queue() here is wrong.  This might cause calling of
start_xmit routine on txfull state and trigger tx-ring overflow.

This fix is ported from commit 662a96bd
("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").
Signed-off-by: default avatarAtsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fbc450b1
...@@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id) ...@@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id)
/* Transmit complete. */ /* Transmit complete. */
net_tx(dev); net_tx(dev);
np->stats.tx_packets++; np->stats.tx_packets++;
netif_wake_queue(dev);
} }
#endif #endif
if (status & COUNTERS_INTR) { if (status & COUNTERS_INTR) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment