Commit 9cd15d52 authored by Denis Ciocca's avatar Denis Ciocca Committed by Jonathan Cameron

iio: remove get_irq_data_ready() function pointer and use IRQ number directly

Not even sure why it was there since the beginning. Just use IRQ
number in the sensor_data struct.
Signed-off-by: default avatarDenis Ciocca <denis.ciocca@st.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 48cceecf
...@@ -1169,7 +1169,6 @@ int st_accel_common_probe(struct iio_dev *indio_dev) ...@@ -1169,7 +1169,6 @@ int st_accel_common_probe(struct iio_dev *indio_dev)
struct st_sensor_data *adata = iio_priv(indio_dev); struct st_sensor_data *adata = iio_priv(indio_dev);
struct st_sensors_platform_data *pdata = struct st_sensors_platform_data *pdata =
(struct st_sensors_platform_data *)adata->dev->platform_data; (struct st_sensors_platform_data *)adata->dev->platform_data;
int irq = adata->get_irq_data_ready(indio_dev);
struct iio_chan_spec *channels; struct iio_chan_spec *channels;
size_t channels_size; size_t channels_size;
int err; int err;
...@@ -1217,7 +1216,7 @@ int st_accel_common_probe(struct iio_dev *indio_dev) ...@@ -1217,7 +1216,7 @@ int st_accel_common_probe(struct iio_dev *indio_dev)
if (err < 0) if (err < 0)
goto st_accel_power_off; goto st_accel_power_off;
if (irq > 0) { if (adata->irq > 0) {
err = st_sensors_allocate_trigger(indio_dev, err = st_sensors_allocate_trigger(indio_dev,
ST_ACCEL_TRIGGER_OPS); ST_ACCEL_TRIGGER_OPS);
if (err < 0) if (err < 0)
...@@ -1234,7 +1233,7 @@ int st_accel_common_probe(struct iio_dev *indio_dev) ...@@ -1234,7 +1233,7 @@ int st_accel_common_probe(struct iio_dev *indio_dev)
return 0; return 0;
st_accel_device_register_error: st_accel_device_register_error:
if (irq > 0) if (adata->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_accel_probe_trigger_error: st_accel_probe_trigger_error:
st_accel_deallocate_ring(indio_dev); st_accel_deallocate_ring(indio_dev);
...@@ -1252,7 +1251,7 @@ void st_accel_common_remove(struct iio_dev *indio_dev) ...@@ -1252,7 +1251,7 @@ void st_accel_common_remove(struct iio_dev *indio_dev)
st_sensors_power_disable(indio_dev); st_sensors_power_disable(indio_dev);
iio_device_unregister(indio_dev); iio_device_unregister(indio_dev);
if (adata->get_irq_data_ready(indio_dev) > 0) if (adata->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_accel_deallocate_ring(indio_dev); st_accel_deallocate_ring(indio_dev);
......
...@@ -20,13 +20,6 @@ ...@@ -20,13 +20,6 @@
#define ST_SENSORS_I2C_MULTIREAD 0x80 #define ST_SENSORS_I2C_MULTIREAD 0x80
static unsigned int st_sensors_i2c_get_irq(struct iio_dev *indio_dev)
{
struct st_sensor_data *sdata = iio_priv(indio_dev);
return to_i2c_client(sdata->dev)->irq;
}
static const struct regmap_config st_sensors_i2c_regmap_config = { static const struct regmap_config st_sensors_i2c_regmap_config = {
.reg_bits = 8, .reg_bits = 8,
.val_bits = 8, .val_bits = 8,
...@@ -69,7 +62,7 @@ int st_sensors_i2c_configure(struct iio_dev *indio_dev, ...@@ -69,7 +62,7 @@ int st_sensors_i2c_configure(struct iio_dev *indio_dev,
indio_dev->name = client->name; indio_dev->name = client->name;
sdata->dev = &client->dev; sdata->dev = &client->dev;
sdata->get_irq_data_ready = st_sensors_i2c_get_irq; sdata->irq = client->irq;
return 0; return 0;
} }
......
...@@ -18,13 +18,6 @@ ...@@ -18,13 +18,6 @@
#define ST_SENSORS_SPI_MULTIREAD 0xc0 #define ST_SENSORS_SPI_MULTIREAD 0xc0
static unsigned int st_sensors_spi_get_irq(struct iio_dev *indio_dev)
{
struct st_sensor_data *sdata = iio_priv(indio_dev);
return to_spi_device(sdata->dev)->irq;
}
static const struct regmap_config st_sensors_spi_regmap_config = { static const struct regmap_config st_sensors_spi_regmap_config = {
.reg_bits = 8, .reg_bits = 8,
.val_bits = 8, .val_bits = 8,
...@@ -117,7 +110,7 @@ int st_sensors_spi_configure(struct iio_dev *indio_dev, ...@@ -117,7 +110,7 @@ int st_sensors_spi_configure(struct iio_dev *indio_dev,
indio_dev->name = spi->modalias; indio_dev->name = spi->modalias;
sdata->dev = &spi->dev; sdata->dev = &spi->dev;
sdata->get_irq_data_ready = st_sensors_spi_get_irq; sdata->irq = spi->irq;
return 0; return 0;
} }
......
...@@ -121,9 +121,9 @@ static irqreturn_t st_sensors_irq_thread(int irq, void *p) ...@@ -121,9 +121,9 @@ static irqreturn_t st_sensors_irq_thread(int irq, void *p)
int st_sensors_allocate_trigger(struct iio_dev *indio_dev, int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
const struct iio_trigger_ops *trigger_ops) const struct iio_trigger_ops *trigger_ops)
{ {
int err, irq;
struct st_sensor_data *sdata = iio_priv(indio_dev); struct st_sensor_data *sdata = iio_priv(indio_dev);
unsigned long irq_trig; unsigned long irq_trig;
int err;
sdata->trig = iio_trigger_alloc("%s-trigger", indio_dev->name); sdata->trig = iio_trigger_alloc("%s-trigger", indio_dev->name);
if (sdata->trig == NULL) { if (sdata->trig == NULL) {
...@@ -135,8 +135,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, ...@@ -135,8 +135,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
sdata->trig->ops = trigger_ops; sdata->trig->ops = trigger_ops;
sdata->trig->dev.parent = sdata->dev; sdata->trig->dev.parent = sdata->dev;
irq = sdata->get_irq_data_ready(indio_dev); irq_trig = irqd_get_trigger_type(irq_get_irq_data(sdata->irq));
irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
/* /*
* If the IRQ is triggered on falling edge, we need to mark the * If the IRQ is triggered on falling edge, we need to mark the
* interrupt as active low, if the hardware supports this. * interrupt as active low, if the hardware supports this.
...@@ -206,7 +205,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, ...@@ -206,7 +205,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
sdata->sensor_settings->drdy_irq.stat_drdy.addr) sdata->sensor_settings->drdy_irq.stat_drdy.addr)
irq_trig |= IRQF_SHARED; irq_trig |= IRQF_SHARED;
err = request_threaded_irq(sdata->get_irq_data_ready(indio_dev), err = request_threaded_irq(sdata->irq,
st_sensors_irq_handler, st_sensors_irq_handler,
st_sensors_irq_thread, st_sensors_irq_thread,
irq_trig, irq_trig,
...@@ -227,7 +226,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev, ...@@ -227,7 +226,7 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
return 0; return 0;
iio_trigger_register_error: iio_trigger_register_error:
free_irq(sdata->get_irq_data_ready(indio_dev), sdata->trig); free_irq(sdata->irq, sdata->trig);
iio_trigger_free: iio_trigger_free:
iio_trigger_free(sdata->trig); iio_trigger_free(sdata->trig);
return err; return err;
...@@ -239,7 +238,7 @@ void st_sensors_deallocate_trigger(struct iio_dev *indio_dev) ...@@ -239,7 +238,7 @@ void st_sensors_deallocate_trigger(struct iio_dev *indio_dev)
struct st_sensor_data *sdata = iio_priv(indio_dev); struct st_sensor_data *sdata = iio_priv(indio_dev);
iio_trigger_unregister(sdata->trig); iio_trigger_unregister(sdata->trig);
free_irq(sdata->get_irq_data_ready(indio_dev), sdata->trig); free_irq(sdata->irq, sdata->trig);
iio_trigger_free(sdata->trig); iio_trigger_free(sdata->trig);
} }
EXPORT_SYMBOL(st_sensors_deallocate_trigger); EXPORT_SYMBOL(st_sensors_deallocate_trigger);
......
...@@ -388,7 +388,6 @@ EXPORT_SYMBOL(st_gyro_get_settings); ...@@ -388,7 +388,6 @@ EXPORT_SYMBOL(st_gyro_get_settings);
int st_gyro_common_probe(struct iio_dev *indio_dev) int st_gyro_common_probe(struct iio_dev *indio_dev)
{ {
struct st_sensor_data *gdata = iio_priv(indio_dev); struct st_sensor_data *gdata = iio_priv(indio_dev);
int irq = gdata->get_irq_data_ready(indio_dev);
int err; int err;
indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->modes = INDIO_DIRECT_MODE;
...@@ -419,7 +418,7 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) ...@@ -419,7 +418,7 @@ int st_gyro_common_probe(struct iio_dev *indio_dev)
if (err < 0) if (err < 0)
goto st_gyro_power_off; goto st_gyro_power_off;
if (irq > 0) { if (gdata->irq > 0) {
err = st_sensors_allocate_trigger(indio_dev, err = st_sensors_allocate_trigger(indio_dev,
ST_GYRO_TRIGGER_OPS); ST_GYRO_TRIGGER_OPS);
if (err < 0) if (err < 0)
...@@ -436,7 +435,7 @@ int st_gyro_common_probe(struct iio_dev *indio_dev) ...@@ -436,7 +435,7 @@ int st_gyro_common_probe(struct iio_dev *indio_dev)
return 0; return 0;
st_gyro_device_register_error: st_gyro_device_register_error:
if (irq > 0) if (gdata->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_gyro_probe_trigger_error: st_gyro_probe_trigger_error:
st_gyro_deallocate_ring(indio_dev); st_gyro_deallocate_ring(indio_dev);
...@@ -454,7 +453,7 @@ void st_gyro_common_remove(struct iio_dev *indio_dev) ...@@ -454,7 +453,7 @@ void st_gyro_common_remove(struct iio_dev *indio_dev)
st_sensors_power_disable(indio_dev); st_sensors_power_disable(indio_dev);
iio_device_unregister(indio_dev); iio_device_unregister(indio_dev);
if (gdata->get_irq_data_ready(indio_dev) > 0) if (gdata->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_gyro_deallocate_ring(indio_dev); st_gyro_deallocate_ring(indio_dev);
......
...@@ -490,7 +490,6 @@ EXPORT_SYMBOL(st_magn_get_settings); ...@@ -490,7 +490,6 @@ EXPORT_SYMBOL(st_magn_get_settings);
int st_magn_common_probe(struct iio_dev *indio_dev) int st_magn_common_probe(struct iio_dev *indio_dev)
{ {
struct st_sensor_data *mdata = iio_priv(indio_dev); struct st_sensor_data *mdata = iio_priv(indio_dev);
int irq = mdata->get_irq_data_ready(indio_dev);
int err; int err;
indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->modes = INDIO_DIRECT_MODE;
...@@ -520,7 +519,7 @@ int st_magn_common_probe(struct iio_dev *indio_dev) ...@@ -520,7 +519,7 @@ int st_magn_common_probe(struct iio_dev *indio_dev)
if (err < 0) if (err < 0)
goto st_magn_power_off; goto st_magn_power_off;
if (irq > 0) { if (mdata->irq > 0) {
err = st_sensors_allocate_trigger(indio_dev, err = st_sensors_allocate_trigger(indio_dev,
ST_MAGN_TRIGGER_OPS); ST_MAGN_TRIGGER_OPS);
if (err < 0) if (err < 0)
...@@ -537,7 +536,7 @@ int st_magn_common_probe(struct iio_dev *indio_dev) ...@@ -537,7 +536,7 @@ int st_magn_common_probe(struct iio_dev *indio_dev)
return 0; return 0;
st_magn_device_register_error: st_magn_device_register_error:
if (irq > 0) if (mdata->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_magn_probe_trigger_error: st_magn_probe_trigger_error:
st_magn_deallocate_ring(indio_dev); st_magn_deallocate_ring(indio_dev);
...@@ -555,7 +554,7 @@ void st_magn_common_remove(struct iio_dev *indio_dev) ...@@ -555,7 +554,7 @@ void st_magn_common_remove(struct iio_dev *indio_dev)
st_sensors_power_disable(indio_dev); st_sensors_power_disable(indio_dev);
iio_device_unregister(indio_dev); iio_device_unregister(indio_dev);
if (mdata->get_irq_data_ready(indio_dev) > 0) if (mdata->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_magn_deallocate_ring(indio_dev); st_magn_deallocate_ring(indio_dev);
......
...@@ -686,7 +686,6 @@ int st_press_common_probe(struct iio_dev *indio_dev) ...@@ -686,7 +686,6 @@ int st_press_common_probe(struct iio_dev *indio_dev)
struct st_sensor_data *press_data = iio_priv(indio_dev); struct st_sensor_data *press_data = iio_priv(indio_dev);
struct st_sensors_platform_data *pdata = struct st_sensors_platform_data *pdata =
(struct st_sensors_platform_data *)press_data->dev->platform_data; (struct st_sensors_platform_data *)press_data->dev->platform_data;
int irq = press_data->get_irq_data_ready(indio_dev);
int err; int err;
indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->modes = INDIO_DIRECT_MODE;
...@@ -729,7 +728,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) ...@@ -729,7 +728,7 @@ int st_press_common_probe(struct iio_dev *indio_dev)
if (err < 0) if (err < 0)
goto st_press_power_off; goto st_press_power_off;
if (irq > 0) { if (press_data->irq > 0) {
err = st_sensors_allocate_trigger(indio_dev, err = st_sensors_allocate_trigger(indio_dev,
ST_PRESS_TRIGGER_OPS); ST_PRESS_TRIGGER_OPS);
if (err < 0) if (err < 0)
...@@ -746,7 +745,7 @@ int st_press_common_probe(struct iio_dev *indio_dev) ...@@ -746,7 +745,7 @@ int st_press_common_probe(struct iio_dev *indio_dev)
return err; return err;
st_press_device_register_error: st_press_device_register_error:
if (irq > 0) if (press_data->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_press_probe_trigger_error: st_press_probe_trigger_error:
st_press_deallocate_ring(indio_dev); st_press_deallocate_ring(indio_dev);
...@@ -764,7 +763,7 @@ void st_press_common_remove(struct iio_dev *indio_dev) ...@@ -764,7 +763,7 @@ void st_press_common_remove(struct iio_dev *indio_dev)
st_sensors_power_disable(indio_dev); st_sensors_power_disable(indio_dev);
iio_device_unregister(indio_dev); iio_device_unregister(indio_dev);
if (press_data->get_irq_data_ready(indio_dev) > 0) if (press_data->irq > 0)
st_sensors_deallocate_trigger(indio_dev); st_sensors_deallocate_trigger(indio_dev);
st_press_deallocate_ring(indio_dev); st_press_deallocate_ring(indio_dev);
......
...@@ -220,7 +220,7 @@ struct st_sensor_settings { ...@@ -220,7 +220,7 @@ struct st_sensor_settings {
* num_data_channels: Number of data channels used in buffer. * num_data_channels: Number of data channels used in buffer.
* @drdy_int_pin: Redirect DRDY on pin 1 (1) or pin 2 (2). * @drdy_int_pin: Redirect DRDY on pin 1 (1) or pin 2 (2).
* @int_pin_open_drain: Set the interrupt/DRDY to open drain. * @int_pin_open_drain: Set the interrupt/DRDY to open drain.
* @get_irq_data_ready: Function to get the IRQ used for data ready signal. * @irq: the IRQ number.
* @edge_irq: the IRQ triggers on edges and need special handling. * @edge_irq: the IRQ triggers on edges and need special handling.
* @hw_irq_trigger: if we're using the hardware interrupt on the sensor. * @hw_irq_trigger: if we're using the hardware interrupt on the sensor.
* @hw_timestamp: Latest timestamp from the interrupt handler, when in use. * @hw_timestamp: Latest timestamp from the interrupt handler, when in use.
...@@ -244,8 +244,7 @@ struct st_sensor_data { ...@@ -244,8 +244,7 @@ struct st_sensor_data {
u8 drdy_int_pin; u8 drdy_int_pin;
bool int_pin_open_drain; bool int_pin_open_drain;
int irq;
unsigned int (*get_irq_data_ready) (struct iio_dev *indio_dev);
bool edge_irq; bool edge_irq;
bool hw_irq_trigger; bool hw_irq_trigger;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment