Commit 9d15e5cc authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

mdio: mux: fix an incorrect less than zero error check using a u32

The u32 variable v is being checked to see if an error return is
less than zero and this check has no effect because it is unsigned.
Fix this by making v and int (this also matches the type of
cb->bus_number which is assigned to the value in v).

Detected by CoverityScan, CID#1440454 ("Unsigned compared against zero")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2f878491
...@@ -133,7 +133,7 @@ int mdio_mux_init(struct device *dev, ...@@ -133,7 +133,7 @@ int mdio_mux_init(struct device *dev,
ret_val = -ENODEV; ret_val = -ENODEV;
for_each_available_child_of_node(dev->of_node, child_bus_node) { for_each_available_child_of_node(dev->of_node, child_bus_node) {
u32 v; int v;
v = of_mdio_parse_addr(dev, child_bus_node); v = of_mdio_parse_addr(dev, child_bus_node);
if (v < 0) { if (v < 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment