Commit a20852d2 authored by Heiko Carstens's avatar Heiko Carstens Committed by Martin Schwidefsky

[S390] cmm: fix crash on case conversion

When the cmm module is compiled into the kernel it will crash when
writing to the R/O data section.
Reason is the lower to upper case conversion of the "sender" module
parameter which ignored the fact that the pointer is preinitialized.

Introduced with 41b42876 "cmm, smsgiucv_app: convert sender to
uppercase"
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent bf2106ae
...@@ -23,7 +23,10 @@ ...@@ -23,7 +23,10 @@
#include <asm/pgalloc.h> #include <asm/pgalloc.h>
#include <asm/diag.h> #include <asm/diag.h>
static char *sender = "VMRMSVM"; #ifdef CONFIG_CMM_IUCV
static char *cmm_default_sender = "VMRMSVM";
#endif
static char *sender;
module_param(sender, charp, 0400); module_param(sender, charp, 0400);
MODULE_PARM_DESC(sender, MODULE_PARM_DESC(sender,
"Guest name that may send SMSG messages (default VMRMSVM)"); "Guest name that may send SMSG messages (default VMRMSVM)");
...@@ -440,6 +443,8 @@ static int __init cmm_init(void) ...@@ -440,6 +443,8 @@ static int __init cmm_init(void)
int len = strlen(sender); int len = strlen(sender);
while (len--) while (len--)
sender[len] = toupper(sender[len]); sender[len] = toupper(sender[len]);
} else {
sender = cmm_default_sender;
} }
rc = smsg_register_callback(SMSG_PREFIX, cmm_smsg_target); rc = smsg_register_callback(SMSG_PREFIX, cmm_smsg_target);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment