Commit a2b520b7 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: rtd520: remove RtdInterruptClear macro

This macro uses the 'devpriv' macro which relies on a local variable
having a specific name. Plus it's just a wrapper around a simple
'readw'. Remove the macro.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent acef7c0f
...@@ -406,10 +406,6 @@ struct rtdPrivate { ...@@ -406,10 +406,6 @@ struct rtdPrivate {
/* Macros to access registers */ /* Macros to access registers */
/* Interrupt status clear (only bits set in mask) */
#define RtdInterruptClear(dev) \
readw(devpriv->las0+LAS0_CLEAR)
/* Interrupt clear mask */ /* Interrupt clear mask */
#define RtdInterruptClearMask(dev, v) \ #define RtdInterruptClearMask(dev, v) \
writew((devpriv->intClearMask = (v)), devpriv->las0+LAS0_CLEAR) writew((devpriv->intClearMask = (v)), devpriv->las0+LAS0_CLEAR)
...@@ -1129,7 +1125,7 @@ static irqreturn_t rtd_interrupt(int irq, /* interrupt number (ignored) */ ...@@ -1129,7 +1125,7 @@ static irqreturn_t rtd_interrupt(int irq, /* interrupt number (ignored) */
/* clear the interrupt */ /* clear the interrupt */
RtdInterruptClearMask(dev, status); RtdInterruptClearMask(dev, status);
RtdInterruptClear(dev); readw(devpriv->las0 + LAS0_CLEAR);
return IRQ_HANDLED; return IRQ_HANDLED;
abortTransfer: abortTransfer:
...@@ -1170,7 +1166,7 @@ static irqreturn_t rtd_interrupt(int irq, /* interrupt number (ignored) */ ...@@ -1170,7 +1166,7 @@ static irqreturn_t rtd_interrupt(int irq, /* interrupt number (ignored) */
/* clear the interrupt */ /* clear the interrupt */
status = readw(devpriv->las0 + LAS0_IT); status = readw(devpriv->las0 + LAS0_IT);
RtdInterruptClearMask(dev, status); RtdInterruptClearMask(dev, status);
RtdInterruptClear(dev); readw(devpriv->las0 + LAS0_CLEAR);
fifoStatus = readl(devpriv->las0 + LAS0_ADC); fifoStatus = readl(devpriv->las0 + LAS0_ADC);
DPRINTK DPRINTK
...@@ -1565,7 +1561,7 @@ static int rtd_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s) ...@@ -1565,7 +1561,7 @@ static int rtd_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
/* This doesn't seem to work. There is no way to clear an interrupt /* This doesn't seem to work. There is no way to clear an interrupt
that the priority controller has queued! */ that the priority controller has queued! */
RtdInterruptClearMask(dev, ~0); /* clear any existing flags */ RtdInterruptClearMask(dev, ~0); /* clear any existing flags */
RtdInterruptClear(dev); readw(devpriv->las0 + LAS0_CLEAR);
/* TODO: allow multiple interrupt sources */ /* TODO: allow multiple interrupt sources */
if (devpriv->transCount > 0) { /* transfer every N samples */ if (devpriv->transCount > 0) { /* transfer every N samples */
...@@ -1968,7 +1964,7 @@ static int rtd_attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -1968,7 +1964,7 @@ static int rtd_attach(struct comedi_device *dev, struct comedi_devconfig *it)
devpriv->intMask = 0; devpriv->intMask = 0;
writew(devpriv->intMask, devpriv->las0 + LAS0_IT); writew(devpriv->intMask, devpriv->las0 + LAS0_IT);
RtdInterruptClearMask(dev, ~0); /* and sets shadow */ RtdInterruptClearMask(dev, ~0); /* and sets shadow */
RtdInterruptClear(dev); /* clears bits set by mask */ readw(devpriv->las0 + LAS0_CLEAR);
RtdInterruptOverrunClear(dev); RtdInterruptOverrunClear(dev);
writel(0, devpriv->las0 + LAS0_CGT_CLEAR); writel(0, devpriv->las0 + LAS0_CGT_CLEAR);
writel(0, devpriv->las0 + LAS0_ADC_FIFO_CLEAR); writel(0, devpriv->las0 + LAS0_ADC_FIFO_CLEAR);
...@@ -2148,7 +2144,7 @@ static void rtd_detach(struct comedi_device *dev) ...@@ -2148,7 +2144,7 @@ static void rtd_detach(struct comedi_device *dev)
devpriv->intMask = 0; devpriv->intMask = 0;
writew(devpriv->intMask, devpriv->las0 + LAS0_IT); writew(devpriv->intMask, devpriv->las0 + LAS0_IT);
RtdInterruptClearMask(dev, ~0); RtdInterruptClearMask(dev, ~0);
RtdInterruptClear(dev); /* clears bits set by mask */ readw(devpriv->las0 + LAS0_CLEAR);
} }
#ifdef USE_DMA #ifdef USE_DMA
/* release DMA */ /* release DMA */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment