Commit a2ea6ed6 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Herbert Xu

crypto: tcrypt - Fix potential leak in test_aead_speed() if crypto_alloc_aead() fails

Fix a potential memory leak in the error handling of test_aead_speed(). In case
crypto_alloc_aead() fails, the function returns without going through the
centralized cleanup path. Reported by Coverity - CID 1163870.
Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Acked-by: default avatarTim Chen <tim.c.chen@linux.intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ac5f863f
...@@ -313,7 +313,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec, ...@@ -313,7 +313,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec,
if (IS_ERR(tfm)) { if (IS_ERR(tfm)) {
pr_err("alg: aead: Failed to load transform for %s: %ld\n", algo, pr_err("alg: aead: Failed to load transform for %s: %ld\n", algo,
PTR_ERR(tfm)); PTR_ERR(tfm));
return; goto out_notfm;
} }
req = aead_request_alloc(tfm, GFP_KERNEL); req = aead_request_alloc(tfm, GFP_KERNEL);
...@@ -391,6 +391,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec, ...@@ -391,6 +391,7 @@ static void test_aead_speed(const char *algo, int enc, unsigned int sec,
out: out:
crypto_free_aead(tfm); crypto_free_aead(tfm);
out_notfm:
kfree(sg); kfree(sg);
out_nosg: out_nosg:
testmgr_free_buf(xoutbuf); testmgr_free_buf(xoutbuf);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment