Commit a2fa9b8e authored by Alexandre Belloni's avatar Alexandre Belloni

rtc: tx4939: fix possible race condition

The probe function is not allowed to fail after registering the RTC. Call
rtc_register_device() at the end.
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 68981fd1
...@@ -289,12 +289,13 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev) ...@@ -289,12 +289,13 @@ static int __init tx4939_rtc_probe(struct platform_device *pdev)
rtc->ops = &tx4939_rtc_ops; rtc->ops = &tx4939_rtc_ops;
ret = rtc_register_device(rtc); ret = sysfs_create_bin_file(&pdev->dev.kobj, &tx4939_rtc_nvram_attr);
if (ret) if (ret)
return ret; return ret;
pdata->rtc = rtc; pdata->rtc = rtc;
ret = sysfs_create_bin_file(&pdev->dev.kobj, &tx4939_rtc_nvram_attr);
ret = rtc_register_device(rtc);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment