Commit a3c463e0 authored by Archit Taneja's avatar Archit Taneja Committed by Rob Clark

dt-bindings: msm/dsi: Some binding doc cleanups

Some cleanups:

- Use simpler names for DT nodes in the example
- Use references instead of dumping Document links everywhere
Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarArchit Taneja <architt@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent 9097209d
...@@ -11,7 +11,7 @@ Required properties: ...@@ -11,7 +11,7 @@ Required properties:
be 0 or 1, since we have 2 DSI controllers at most for now. be 0 or 1, since we have 2 DSI controllers at most for now.
- interrupts: The interrupt signal from the DSI block. - interrupts: The interrupt signal from the DSI block.
- power-domains: Should be <&mmcc MDSS_GDSC>. - power-domains: Should be <&mmcc MDSS_GDSC>.
- clocks: device clocks - clocks: Phandles to device clocks.
- clock-names: the following clocks are required: - clock-names: the following clocks are required:
* "mdp_core_clk" * "mdp_core_clk"
* "iface_clk" * "iface_clk"
...@@ -24,8 +24,7 @@ Required properties: ...@@ -24,8 +24,7 @@ Required properties:
* "src_clk" * "src_clk"
- assigned-clocks: Parents of "byte_clk" and "pixel_clk" for the given platform. - assigned-clocks: Parents of "byte_clk" and "pixel_clk" for the given platform.
- assigned-clock-parents: The Byte clock and Pixel clock PLL outputs provided - assigned-clock-parents: The Byte clock and Pixel clock PLL outputs provided
by a DSI PHY block. by a DSI PHY block. See [1] for details on clock bindings.
See Documentation/devicetree/bindings/clocks/clock-bindings.txt for details.
- vdd-supply: phandle to vdd regulator device node - vdd-supply: phandle to vdd regulator device node
- vddio-supply: phandle to vdd-io regulator device node - vddio-supply: phandle to vdd-io regulator device node
- vdda-supply: phandle to vdda regulator device node - vdda-supply: phandle to vdda regulator device node
...@@ -33,15 +32,11 @@ Required properties: ...@@ -33,15 +32,11 @@ Required properties:
- phy-names: the name of the corresponding PHY device - phy-names: the name of the corresponding PHY device
- syscon-sfpb: A phandle to mmss_sfpb syscon node (only for DSIv2) - syscon-sfpb: A phandle to mmss_sfpb syscon node (only for DSIv2)
- ports: Contains 2 DSI controller ports as child nodes. Each port contains - ports: Contains 2 DSI controller ports as child nodes. Each port contains
an endpoint subnode as defined in these documents: an endpoint subnode as defined in [2] and [3].
Documentation/devicetree/bindings/graph.txt
Documentation/devicetree/bindings/media/video-interfaces.txt
Optional properties: Optional properties:
- panel@0: Node of panel connected to this DSI controller. - panel@0: Node of panel connected to this DSI controller.
See files in Documentation/devicetree/bindings/display/panel/ for each supported See files in [4] for each supported panel.
panel.
- qcom,dual-dsi-mode: Boolean value indicating if the DSI controller is - qcom,dual-dsi-mode: Boolean value indicating if the DSI controller is
driving a panel which needs 2 DSI links. driving a panel which needs 2 DSI links.
- qcom,master-dsi: Boolean value indicating if the DSI controller is driving - qcom,master-dsi: Boolean value indicating if the DSI controller is driving
...@@ -58,15 +53,15 @@ Optional properties: ...@@ -58,15 +53,15 @@ Optional properties:
DSI Endpoint properties: DSI Endpoint properties:
- remote-endpoint: For port@0, set to phandle of the connected panel/bridge's - remote-endpoint: For port@0, set to phandle of the connected panel/bridge's
input endpoint. For port@1, set to the MDP interface output. input endpoint. For port@1, set to the MDP interface output. See [2] for
See Documentation/devicetree/bindings/graph.txt for device graph info. device graph info.
- data-lanes: this describes how the physical DSI data lanes are mapped - data-lanes: this describes how the physical DSI data lanes are mapped
to the logical lanes on the given platform. The value contained in to the logical lanes on the given platform. The value contained in
index n describes what physical lane is mapped to the logical lane n index n describes what physical lane is mapped to the logical lane n
(DATAn, where n lies between 0 and 3). The clock lane position is fixed (DATAn, where n lies between 0 and 3). The clock lane position is fixed
and can't be changed. Hence, they aren't a part of the DT bindings. For and can't be changed. Hence, they aren't a part of the DT bindings. See
more info, see Documentation/devicetree/bindings/media/video-interfaces.txt [3] for more info on the data-lanes property.
For example: For example:
...@@ -104,8 +99,7 @@ Required properties: ...@@ -104,8 +99,7 @@ Required properties:
- qcom,dsi-phy-index: The ID of DSI PHY hardware instance. This should - qcom,dsi-phy-index: The ID of DSI PHY hardware instance. This should
be 0 or 1, since we have 2 DSI PHYs at most for now. be 0 or 1, since we have 2 DSI PHYs at most for now.
- power-domains: Should be <&mmcc MDSS_GDSC>. - power-domains: Should be <&mmcc MDSS_GDSC>.
- clocks: device clocks - clocks: Phandles to device clocks. See [1] for details on clock bindings.
See Documentation/devicetree/bindings/clocks/clock-bindings.txt for details.
- clock-names: the following clocks are required: - clock-names: the following clocks are required:
* "iface_clk" * "iface_clk"
- vddio-supply: phandle to vdd-io regulator device node - vddio-supply: phandle to vdd-io regulator device node
...@@ -114,11 +108,16 @@ Optional properties: ...@@ -114,11 +108,16 @@ Optional properties:
- qcom,dsi-phy-regulator-ldo-mode: Boolean value indicating if the LDO mode PHY - qcom,dsi-phy-regulator-ldo-mode: Boolean value indicating if the LDO mode PHY
regulator is wanted. regulator is wanted.
[1] Documentation/devicetree/bindings/clocks/clock-bindings.txt
[2] Documentation/devicetree/bindings/graph.txt
[3] Documentation/devicetree/bindings/media/video-interfaces.txt
[4] Documentation/devicetree/bindings/display/panel/
Example: Example:
mdss_dsi0: qcom,mdss_dsi@fd922800 { dsi0: dsi@fd922800 {
compatible = "qcom,mdss-dsi-ctrl"; compatible = "qcom,mdss-dsi-ctrl";
qcom,dsi-host-index = <0>; qcom,dsi-host-index = <0>;
interrupt-parent = <&mdss_mdp>; interrupt-parent = <&mdp>;
interrupts = <4 0>; interrupts = <4 0>;
reg-names = "dsi_ctrl"; reg-names = "dsi_ctrl";
reg = <0xfd922800 0x200>; reg = <0xfd922800 0x200>;
...@@ -144,14 +143,14 @@ Example: ...@@ -144,14 +143,14 @@ Example:
<&mmcc BYTE0_CLK_SRC>, <&mmcc BYTE0_CLK_SRC>,
<&mmcc PCLK0_CLK_SRC>; <&mmcc PCLK0_CLK_SRC>;
assigned-clock-parents = assigned-clock-parents =
<&mdss_dsi_phy0 0>, <&dsi_phy0 0>,
<&mdss_dsi_phy0 1>; <&dsi_phy0 1>;
vdda-supply = <&pma8084_l2>; vdda-supply = <&pma8084_l2>;
vdd-supply = <&pma8084_l22>; vdd-supply = <&pma8084_l22>;
vddio-supply = <&pma8084_l12>; vddio-supply = <&pma8084_l12>;
phys = <&mdss_dsi_phy0>; phys = <&dsi_phy0>;
phy-names ="dsi-phy"; phy-names ="dsi-phy";
qcom,dual-dsi-mode; qcom,dual-dsi-mode;
...@@ -159,8 +158,8 @@ Example: ...@@ -159,8 +158,8 @@ Example:
qcom,sync-dual-dsi; qcom,sync-dual-dsi;
pinctrl-names = "default", "sleep"; pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_active>; pinctrl-0 = <&dsi_active>;
pinctrl-1 = <&mdss_dsi_suspend>; pinctrl-1 = <&dsi_suspend>;
ports { ports {
#address-cells = <1>; #address-cells = <1>;
...@@ -198,7 +197,7 @@ Example: ...@@ -198,7 +197,7 @@ Example:
}; };
}; };
mdss_dsi_phy0: qcom,mdss_dsi_phy@fd922a00 { dsi_phy0: dsi-phy@fd922a00 {
compatible = "qcom,dsi-phy-28nm-hpm"; compatible = "qcom,dsi-phy-28nm-hpm";
qcom,dsi-phy-index = <0>; qcom,dsi-phy-index = <0>;
reg-names = reg-names =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment