ovl: fix creds leak in copy up error path

commit 8137ae26 upstream.

Fixes: 42f269b9 ("ovl: rearrange code in ovl_copy_up_locked()")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

fs/overlayfs/copy_up.c

@@ -269,12 +269,13 @@ static int ovl_copy_up_locked(struct dentry *workdir, struct dentry *upperdir,
 		temp = ovl_do_tmpfile(upperdir, stat->mode);
 	else
 		temp = ovl_lookup_temp(workdir, dentry);
+	err = 0;
+	if (IS_ERR(temp)) {
 		err = PTR_ERR(temp);
-	if (IS_ERR(temp))
-		goto out1;
+		temp = NULL;
+	}
 
-	err = 0;
-	if (!tmpfile)
+	if (!err && !tmpfile)
 		err = ovl_create_real(wdir, temp, &cattr, NULL, true);
 
 	if (new_creds) {