Commit a9e64931 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin

drm/i915: No need to save/restore irq status in intel_breadcrumbs_fake_irq

Timer callback is a known context so it is correct to always
disable interrupts.
Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent 2c33b541
...@@ -109,7 +109,6 @@ static void intel_breadcrumbs_fake_irq(unsigned long data) ...@@ -109,7 +109,6 @@ static void intel_breadcrumbs_fake_irq(unsigned long data)
{ {
struct intel_engine_cs *engine = (struct intel_engine_cs *)data; struct intel_engine_cs *engine = (struct intel_engine_cs *)data;
struct intel_breadcrumbs *b = &engine->breadcrumbs; struct intel_breadcrumbs *b = &engine->breadcrumbs;
unsigned long flags;
/* /*
* The timer persists in case we cannot enable interrupts, * The timer persists in case we cannot enable interrupts,
...@@ -119,10 +118,10 @@ static void intel_breadcrumbs_fake_irq(unsigned long data) ...@@ -119,10 +118,10 @@ static void intel_breadcrumbs_fake_irq(unsigned long data)
* coherent seqno check. * coherent seqno check.
*/ */
spin_lock_irqsave(&b->irq_lock, flags); spin_lock_irq(&b->irq_lock);
if (!__intel_breadcrumbs_wakeup(b)) if (!__intel_breadcrumbs_wakeup(b))
__intel_engine_disarm_breadcrumbs(engine); __intel_engine_disarm_breadcrumbs(engine);
spin_unlock_irqrestore(&b->irq_lock, flags); spin_unlock_irq(&b->irq_lock);
if (!b->irq_armed) if (!b->irq_armed)
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment