Commit ab73ef46 authored by Nikolay Borisov's avatar Nikolay Borisov Committed by Jan Kara

quota: Fix possible GPF due to uninitialised pointers

When dqget() in __dquot_initialize() fails e.g. due to IO error,
__dquot_initialize() will pass an array of uninitialized pointers to
dqput_all() and thus can lead to deference of random data. Fix the
problem by properly initializing the array.

CC: stable@vger.kernel.org
Signed-off-by: default avatarNikolay Borisov <kernel@kyup.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 6332b9b5
...@@ -1410,7 +1410,7 @@ static int dquot_active(const struct inode *inode) ...@@ -1410,7 +1410,7 @@ static int dquot_active(const struct inode *inode)
static int __dquot_initialize(struct inode *inode, int type) static int __dquot_initialize(struct inode *inode, int type)
{ {
int cnt, init_needed = 0; int cnt, init_needed = 0;
struct dquot **dquots, *got[MAXQUOTAS]; struct dquot **dquots, *got[MAXQUOTAS] = {};
struct super_block *sb = inode->i_sb; struct super_block *sb = inode->i_sb;
qsize_t rsv; qsize_t rsv;
int ret = 0; int ret = 0;
...@@ -1427,7 +1427,6 @@ static int __dquot_initialize(struct inode *inode, int type) ...@@ -1427,7 +1427,6 @@ static int __dquot_initialize(struct inode *inode, int type)
int rc; int rc;
struct dquot *dquot; struct dquot *dquot;
got[cnt] = NULL;
if (type != -1 && cnt != type) if (type != -1 && cnt != type)
continue; continue;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment