Commit ac39849d authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Theodore Ts'o

ext4: sparse fixes

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
parent d8dd0b45
...@@ -47,7 +47,7 @@ int ext4_sync_file(struct file * file, struct dentry *dentry, int datasync) ...@@ -47,7 +47,7 @@ int ext4_sync_file(struct file * file, struct dentry *dentry, int datasync)
struct inode *inode = dentry->d_inode; struct inode *inode = dentry->d_inode;
int ret = 0; int ret = 0;
J_ASSERT(ext4_journal_current_handle() == 0); J_ASSERT(ext4_journal_current_handle() == NULL);
/* /*
* data=writeback: * data=writeback:
......
...@@ -1027,7 +1027,7 @@ struct buffer_head *ext4_getblk(handle_t *handle, struct inode *inode, ...@@ -1027,7 +1027,7 @@ struct buffer_head *ext4_getblk(handle_t *handle, struct inode *inode,
} }
if (buffer_new(&dummy)) { if (buffer_new(&dummy)) {
J_ASSERT(create != 0); J_ASSERT(create != 0);
J_ASSERT(handle != 0); J_ASSERT(handle != NULL);
/* /*
* Now that we do not always journal data, we should * Now that we do not always journal data, we should
......
...@@ -1120,7 +1120,7 @@ int ext4_expand_extra_isize_ea(struct inode *inode, int new_extra_isize, ...@@ -1120,7 +1120,7 @@ int ext4_expand_extra_isize_ea(struct inode *inode, int new_extra_isize,
int total_ino, total_blk; int total_ino, total_blk;
void *base, *start, *end; void *base, *start, *end;
int extra_isize = 0, error = 0, tried_min_extra_isize = 0; int extra_isize = 0, error = 0, tried_min_extra_isize = 0;
int s_min_extra_isize = EXT4_SB(inode->i_sb)->s_es->s_min_extra_isize; int s_min_extra_isize = le16_to_cpu(EXT4_SB(inode->i_sb)->s_es->s_min_extra_isize);
down_write(&EXT4_I(inode)->xattr_sem); down_write(&EXT4_I(inode)->xattr_sem);
retry: retry:
...@@ -1292,7 +1292,7 @@ int ext4_expand_extra_isize_ea(struct inode *inode, int new_extra_isize, ...@@ -1292,7 +1292,7 @@ int ext4_expand_extra_isize_ea(struct inode *inode, int new_extra_isize,
i.name = b_entry_name; i.name = b_entry_name;
i.value = buffer; i.value = buffer;
i.value_len = cpu_to_le32(size); i.value_len = size;
error = ext4_xattr_block_find(inode, &i, bs); error = ext4_xattr_block_find(inode, &i, bs);
if (error) if (error)
goto cleanup; goto cleanup;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment