Commit add3d95d authored by Tom St Denis's avatar Tom St Denis Committed by Alex Deucher

drm/ttm: Simplify ttm_dma_find_pool() (v2)

Flip the logic of the comparison and remove
the redudant variable for the pool address.

(v2): Remove {} bracing.
Signed-off-by: default avatarTom St Denis <tom.stdenis@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent c68edaa0
...@@ -682,10 +682,10 @@ static struct dma_pool *ttm_dma_pool_init(struct device *dev, gfp_t flags, ...@@ -682,10 +682,10 @@ static struct dma_pool *ttm_dma_pool_init(struct device *dev, gfp_t flags,
static struct dma_pool *ttm_dma_find_pool(struct device *dev, static struct dma_pool *ttm_dma_find_pool(struct device *dev,
enum pool_type type) enum pool_type type)
{ {
struct dma_pool *pool, *tmp, *found = NULL; struct dma_pool *pool, *tmp;
if (type == IS_UNDEFINED) if (type == IS_UNDEFINED)
return found; return NULL;
/* NB: We iterate on the 'struct dev' which has no spinlock, but /* NB: We iterate on the 'struct dev' which has no spinlock, but
* it does have a kref which we have taken. The kref is taken during * it does have a kref which we have taken. The kref is taken during
...@@ -698,13 +698,10 @@ static struct dma_pool *ttm_dma_find_pool(struct device *dev, ...@@ -698,13 +698,10 @@ static struct dma_pool *ttm_dma_find_pool(struct device *dev,
* thing is at that point of time there are no pages associated with the * thing is at that point of time there are no pages associated with the
* driver so this function will not be called. * driver so this function will not be called.
*/ */
list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools) { list_for_each_entry_safe(pool, tmp, &dev->dma_pools, pools)
if (pool->type != type) if (pool->type == type)
continue; return pool;
found = pool; return NULL;
break;
}
return found;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment