Commit b148c74d authored by Matt Porter's avatar Matt Porter Committed by Linus Torvalds

[PATCH] Fix warnings in ibm_emac driver

This patch fixes annoying warnings in ibm_emac driver.
Signed-off-by: default avatarEugene Surovegin <ebs@ebshome.net>
Signed-off-by: default avatarMatt Porter <mporter@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent b545069f
...@@ -620,7 +620,7 @@ emac_rx_csum(struct net_device *dev, unsigned short ctrl, struct sk_buff *skb) ...@@ -620,7 +620,7 @@ emac_rx_csum(struct net_device *dev, unsigned short ctrl, struct sk_buff *skb)
static int emac_rx_clean(struct net_device *dev) static int emac_rx_clean(struct net_device *dev)
{ {
int i, b, bnum, buf[6]; int i, b, bnum = 0, buf[6];
int error, frame_length; int error, frame_length;
struct ocp_enet_private *fep = dev->priv; struct ocp_enet_private *fep = dev->priv;
unsigned short ctrl; unsigned short ctrl;
...@@ -1021,7 +1021,6 @@ static int emac_start_xmit(struct sk_buff *skb, struct net_device *dev) ...@@ -1021,7 +1021,6 @@ static int emac_start_xmit(struct sk_buff *skb, struct net_device *dev)
static int emac_adjust_to_link(struct ocp_enet_private *fep) static int emac_adjust_to_link(struct ocp_enet_private *fep)
{ {
emac_t *emacp = fep->emacp; emac_t *emacp = fep->emacp;
struct ibm_ocp_rgmii *rgmii;
unsigned long mode_reg; unsigned long mode_reg;
int full_duplex, speed; int full_duplex, speed;
...@@ -1038,21 +1037,23 @@ static int emac_adjust_to_link(struct ocp_enet_private *fep) ...@@ -1038,21 +1037,23 @@ static int emac_adjust_to_link(struct ocp_enet_private *fep)
speed = fep->phy_mii.speed; speed = fep->phy_mii.speed;
} }
if (fep->rgmii_dev)
rgmii = RGMII_PRIV(fep->rgmii_dev);
/* set speed (default is 10Mb) */ /* set speed (default is 10Mb) */
switch (speed) { switch (speed) {
case SPEED_1000: case SPEED_1000:
mode_reg |= EMAC_M1_JUMBO_ENABLE | EMAC_M1_RFS_16K; mode_reg |= EMAC_M1_JUMBO_ENABLE | EMAC_M1_RFS_16K;
if (fep->rgmii_dev) {
struct ibm_ocp_rgmii *rgmii = RGMII_PRIV(fep->rgmii_dev);
if ((rgmii->mode[fep->rgmii_input] == RTBI) if ((rgmii->mode[fep->rgmii_input] == RTBI)
|| (rgmii->mode[fep->rgmii_input] == TBI)) || (rgmii->mode[fep->rgmii_input] == TBI))
mode_reg |= EMAC_M1_MF_1000GPCS; mode_reg |= EMAC_M1_MF_1000GPCS;
else else
mode_reg |= EMAC_M1_MF_1000MBPS; mode_reg |= EMAC_M1_MF_1000MBPS;
if (fep->rgmii_dev)
emac_rgmii_port_speed(fep->rgmii_dev, fep->rgmii_input, emac_rgmii_port_speed(fep->rgmii_dev, fep->rgmii_input,
1000); 1000);
}
break; break;
case SPEED_100: case SPEED_100:
mode_reg |= EMAC_M1_MF_100MBPS | EMAC_M1_RFS_4K; mode_reg |= EMAC_M1_MF_100MBPS | EMAC_M1_RFS_4K;
......
...@@ -83,6 +83,7 @@ struct ibm_ocp_mal { ...@@ -83,6 +83,7 @@ struct ibm_ocp_mal {
GET_MAL0_STANZA(dcrn) \ GET_MAL0_STANZA(dcrn) \
GET_MAL1_STANZA(dcrn) \ GET_MAL1_STANZA(dcrn) \
default: \ default: \
x = 0; \
BUG(); \ BUG(); \
} \ } \
x; }) x; })
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment