Commit b5e47729 authored by Stefan Richter's avatar Stefan Richter

firewire: nosy: misc cleanups

Extend copyright note to 2007, c.f. Kristian's git log.

Includes:
  - replace some <asm/*.h> by <linux/*.h>
  - add required indirectly included <linux/spinlock.h>
  - order alphabetically

Coding style related changes:
  - change to utf8
  - normalize whitespace
  - normalize comment style
  - remove usages of __FUNCTION__
  - remove an unnecessary cast from void *

Const and static declarations:
  - driver_name is not const in pci_driver.name, drop const qualifier
  - driver_name can be taken from KBUILD_MODNAME
  - the global variable minors[] can and should be static
  - constify struct file_operations instance

Data types:
  - Remove unused struct member struct packet.code.  struct packet is
    only used for driver-internal bookkeeping; it does not appear on the
    wire or in DMA programs or the userspace ABI.  Hence the unused
    member .code can be removed without worries.

Preprocessor macros:
  - unroll a preprocessor macro that containd a return
  - use list_for_each_entry

Printk:
  - add missing terminating \n in some format strings
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent 28646821
#ifndef __nosy_user_h #ifndef __nosy_user_h
#define __nosy_user_h #define __nosy_user_h
#include <asm/ioctl.h> #include <linux/ioctl.h>
#include <asm/types.h> #include <linux/types.h>
#define NOSY_IOC_GET_STATS _IOR('&', 0, struct nosy_stats) #define NOSY_IOC_GET_STATS _IOR('&', 0, struct nosy_stats)
#define NOSY_IOC_START _IO('&', 1) #define NOSY_IOC_START _IO('&', 1)
......
This diff is collapsed.
/* Chip register definitions for PCILynx chipset. Based on pcilynx.h /*
* Chip register definitions for PCILynx chipset. Based on pcilynx.h
* from the Linux 1394 drivers, but modified a bit so the names here * from the Linux 1394 drivers, but modified a bit so the names here
* match the specification exactly (even though they have weird names, * match the specification exactly (even though they have weird names,
* like xxx_OVER_FLOW, or arbitrary abbreviations like SNTRJ for "sent * like xxx_OVER_FLOW, or arbitrary abbreviations like SNTRJ for "sent
...@@ -118,7 +119,6 @@ ...@@ -118,7 +119,6 @@
#define DMA_CHAN_STAT_PKTCMPL (1<<27) #define DMA_CHAN_STAT_PKTCMPL (1<<27)
#define DMA_CHAN_STAT_SPECIALACK (1<<14) #define DMA_CHAN_STAT_SPECIALACK (1<<14)
#define DMA0_CHAN_CTRL 0x110 #define DMA0_CHAN_CTRL 0x110
#define DMA1_CHAN_CTRL 0x130 #define DMA1_CHAN_CTRL 0x130
#define DMA2_CHAN_CTRL 0x150 #define DMA2_CHAN_CTRL 0x150
...@@ -160,7 +160,7 @@ ...@@ -160,7 +160,7 @@
#define DMA2_WORD0_CMP_ENABLE 0xb24 #define DMA2_WORD0_CMP_ENABLE 0xb24
#define DMA3_WORD0_CMP_ENABLE 0xb34 #define DMA3_WORD0_CMP_ENABLE 0xb34
#define DMA4_WORD0_CMP_ENABLE 0xb44 #define DMA4_WORD0_CMP_ENABLE 0xb44
#define DMA_WORD0_CMP_ENABLE(chan) (DMA_SREG(DMA0_WORD0_CMP_ENABLE,chan)) #define DMA_WORD0_CMP_ENABLE(chan) (DMA_SREG(DMA0_WORD0_CMP_ENABLE, chan))
#define DMA0_WORD1_CMP_VALUE 0xb08 #define DMA0_WORD1_CMP_VALUE 0xb08
#define DMA1_WORD1_CMP_VALUE 0xb18 #define DMA1_WORD1_CMP_VALUE 0xb18
...@@ -174,7 +174,7 @@ ...@@ -174,7 +174,7 @@
#define DMA2_WORD1_CMP_ENABLE 0xb2c #define DMA2_WORD1_CMP_ENABLE 0xb2c
#define DMA3_WORD1_CMP_ENABLE 0xb3c #define DMA3_WORD1_CMP_ENABLE 0xb3c
#define DMA4_WORD1_CMP_ENABLE 0xb4c #define DMA4_WORD1_CMP_ENABLE 0xb4c
#define DMA_WORD1_CMP_ENABLE(chan) (DMA_SREG(DMA0_WORD1_CMP_ENABLE,chan)) #define DMA_WORD1_CMP_ENABLE(chan) (DMA_SREG(DMA0_WORD1_CMP_ENABLE, chan))
/* word 1 compare enable flags */ /* word 1 compare enable flags */
#define DMA_WORD1_CMP_MATCH_OTHERBUS (1<<15) #define DMA_WORD1_CMP_MATCH_OTHERBUS (1<<15)
#define DMA_WORD1_CMP_MATCH_BROADCAST (1<<14) #define DMA_WORD1_CMP_MATCH_BROADCAST (1<<14)
...@@ -211,7 +211,6 @@ ...@@ -211,7 +211,6 @@
#define LINK_PHY_WDATA(data) (data<<16) #define LINK_PHY_WDATA(data) (data<<16)
#define LINK_PHY_RADDR(addr) (addr<<8) #define LINK_PHY_RADDR(addr) (addr<<8)
#define LINK_INT_STATUS 0xf14 #define LINK_INT_STATUS 0xf14
#define LINK_INT_ENABLE 0xf18 #define LINK_INT_ENABLE 0xf18
/* status and enable have identical bit numbers */ /* status and enable have identical bit numbers */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment