Commit b5f5933a authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

V4L/DVB: au0828: move dereference below sanity checks

This function has sanity checks to make sure that "dev" is non-null.  I
moved the dereference down below the checks.  In the current code "dev"
is never actually null.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarDevin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 49b7a12c
...@@ -441,7 +441,7 @@ static void au0828_copy_vbi(struct au0828_dev *dev, ...@@ -441,7 +441,7 @@ static void au0828_copy_vbi(struct au0828_dev *dev,
unsigned char *outp, unsigned long len) unsigned char *outp, unsigned long len)
{ {
unsigned char *startwrite, *startread; unsigned char *startwrite, *startread;
int bytesperline = dev->vbi_width; int bytesperline;
int i, j = 0; int i, j = 0;
if (dev == NULL) { if (dev == NULL) {
...@@ -464,6 +464,8 @@ static void au0828_copy_vbi(struct au0828_dev *dev, ...@@ -464,6 +464,8 @@ static void au0828_copy_vbi(struct au0828_dev *dev,
return; return;
} }
bytesperline = dev->vbi_width;
if (dma_q->pos + len > buf->vb.size) if (dma_q->pos + len > buf->vb.size)
len = buf->vb.size - dma_q->pos; len = buf->vb.size - dma_q->pos;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment