Commit b727db94 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones

dt-bindings: mfd: Correct interrupt flags in examples

GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> # for BD70528
Acked-by: Tim Harvey <tharvey@gateworks.com> # for gateworks-gsc.yaml
Acked-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent e8299c73
...@@ -71,7 +71,7 @@ Example: ...@@ -71,7 +71,7 @@ Example:
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>; pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
interrupt-parent = <&pioA>; interrupt-parent = <&pioA>;
interrupts = <45 GPIO_ACTIVE_LOW>; interrupts = <45 IRQ_TYPE_LEVEL_LOW>;
active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>; active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>; active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;
......
...@@ -147,6 +147,7 @@ required: ...@@ -147,6 +147,7 @@ required:
examples: examples:
- | - |
#include <dt-bindings/gpio/gpio.h> #include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
i2c { i2c {
#address-cells = <1>; #address-cells = <1>;
#size-cells = <0>; #size-cells = <0>;
...@@ -155,7 +156,7 @@ examples: ...@@ -155,7 +156,7 @@ examples:
compatible = "gw,gsc"; compatible = "gw,gsc";
reg = <0x20>; reg = <0x20>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <4 GPIO_ACTIVE_LOW>; interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller; interrupt-controller;
#interrupt-cells = <1>; #interrupt-cells = <1>;
#address-cells = <1>; #address-cells = <1>;
......
...@@ -39,7 +39,7 @@ pmic: pmic@4b { ...@@ -39,7 +39,7 @@ pmic: pmic@4b {
compatible = "rohm,bd70528"; compatible = "rohm,bd70528";
reg = <0x4b>; reg = <0x4b>;
interrupt-parent = <&gpio1>; interrupt-parent = <&gpio1>;
interrupts = <29 GPIO_ACTIVE_LOW>; interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
clocks = <&osc 0>; clocks = <&osc 0>;
#clock-cells = <0>; #clock-cells = <0>;
clock-output-names = "bd70528-32k-out"; clock-output-names = "bd70528-32k-out";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment