Commit bb1d34a2 authored by Shawn Guo's avatar Shawn Guo

rtc: mxc_rtc: remove cpu_is_xxx by using platform_device_id

It changes the driver to use platform_device_id rather than cpu_is_xxx
to determine the controller type, and updates the platform code
accordingly.

As the result, mach/hardware.h inclusion gets removed from the driver.
Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Acked-by: default avatarSascha Hauer <s.hauer@pengutronix.de>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: rtc-linux@googlegroups.com
parent 4d62435f
...@@ -106,7 +106,7 @@ int __init mx1_clocks_init(unsigned long fref) ...@@ -106,7 +106,7 @@ int __init mx1_clocks_init(unsigned long fref)
clk_register_clkdev(clk[dummy], "ahb", "imx-fb.0"); clk_register_clkdev(clk[dummy], "ahb", "imx-fb.0");
clk_register_clkdev(clk[hclk], "mshc", NULL); clk_register_clkdev(clk[hclk], "mshc", NULL);
clk_register_clkdev(clk[per3], "ssi", NULL); clk_register_clkdev(clk[per3], "ssi", NULL);
clk_register_clkdev(clk[clk32], NULL, "mxc_rtc.0"); clk_register_clkdev(clk[clk32], NULL, "imx1-rtc.0");
clk_register_clkdev(clk[clko], "clko", NULL); clk_register_clkdev(clk[clko], "clko", NULL);
mxc_timer_init(MX1_IO_ADDRESS(MX1_TIM1_BASE_ADDR), MX1_TIM1_INT); mxc_timer_init(MX1_IO_ADDRESS(MX1_TIM1_BASE_ADDR), MX1_TIM1_INT);
......
...@@ -259,7 +259,7 @@ int __init mx27_clocks_init(unsigned long fref) ...@@ -259,7 +259,7 @@ int __init mx27_clocks_init(unsigned long fref)
clk_register_clkdev(clk[gpio_ipg_gate], "gpio", NULL); clk_register_clkdev(clk[gpio_ipg_gate], "gpio", NULL);
clk_register_clkdev(clk[brom_ahb_gate], "brom", NULL); clk_register_clkdev(clk[brom_ahb_gate], "brom", NULL);
clk_register_clkdev(clk[ata_ahb_gate], "ata", NULL); clk_register_clkdev(clk[ata_ahb_gate], "ata", NULL);
clk_register_clkdev(clk[rtc_ipg_gate], NULL, "mxc_rtc"); clk_register_clkdev(clk[rtc_ipg_gate], NULL, "imx21-rtc");
clk_register_clkdev(clk[scc_ipg_gate], "scc", NULL); clk_register_clkdev(clk[scc_ipg_gate], "scc", NULL);
clk_register_clkdev(clk[cpu_div], "cpu", NULL); clk_register_clkdev(clk[cpu_div], "cpu", NULL);
clk_register_clkdev(clk[emi_ahb_gate], "emi_ahb" , NULL); clk_register_clkdev(clk[emi_ahb_gate], "emi_ahb" , NULL);
......
...@@ -124,7 +124,7 @@ int __init mx31_clocks_init(unsigned long fref) ...@@ -124,7 +124,7 @@ int __init mx31_clocks_init(unsigned long fref)
clk_register_clkdev(clk[cspi3_gate], NULL, "imx31-cspi.2"); clk_register_clkdev(clk[cspi3_gate], NULL, "imx31-cspi.2");
clk_register_clkdev(clk[pwm_gate], "pwm", NULL); clk_register_clkdev(clk[pwm_gate], "pwm", NULL);
clk_register_clkdev(clk[wdog_gate], NULL, "imx2-wdt.0"); clk_register_clkdev(clk[wdog_gate], NULL, "imx2-wdt.0");
clk_register_clkdev(clk[rtc_gate], NULL, "mxc_rtc"); clk_register_clkdev(clk[rtc_gate], NULL, "imx21-rtc");
clk_register_clkdev(clk[epit1_gate], "epit", NULL); clk_register_clkdev(clk[epit1_gate], "epit", NULL);
clk_register_clkdev(clk[epit2_gate], "epit", NULL); clk_register_clkdev(clk[epit2_gate], "epit", NULL);
clk_register_clkdev(clk[nfc], NULL, "imx27-nand.0"); clk_register_clkdev(clk[nfc], NULL, "imx27-nand.0");
......
...@@ -292,6 +292,7 @@ struct platform_device *__init imx_add_mxc_pwm( ...@@ -292,6 +292,7 @@ struct platform_device *__init imx_add_mxc_pwm(
/* mxc_rtc */ /* mxc_rtc */
struct imx_mxc_rtc_data { struct imx_mxc_rtc_data {
const char *devid;
resource_size_t iobase; resource_size_t iobase;
resource_size_t irq; resource_size_t irq;
}; };
......
...@@ -9,20 +9,21 @@ ...@@ -9,20 +9,21 @@
#include <mach/hardware.h> #include <mach/hardware.h>
#include "devices-common.h" #include "devices-common.h"
#define imx_mxc_rtc_data_entry_single(soc) \ #define imx_mxc_rtc_data_entry_single(soc, _devid) \
{ \ { \
.devid = _devid, \
.iobase = soc ## _RTC_BASE_ADDR, \ .iobase = soc ## _RTC_BASE_ADDR, \
.irq = soc ## _INT_RTC, \ .irq = soc ## _INT_RTC, \
} }
#ifdef CONFIG_SOC_IMX31 #ifdef CONFIG_SOC_IMX31
const struct imx_mxc_rtc_data imx31_mxc_rtc_data __initconst = const struct imx_mxc_rtc_data imx31_mxc_rtc_data __initconst =
imx_mxc_rtc_data_entry_single(MX31); imx_mxc_rtc_data_entry_single(MX31, "imx21-rtc");
#endif /* ifdef CONFIG_SOC_IMX31 */ #endif /* ifdef CONFIG_SOC_IMX31 */
#ifdef CONFIG_SOC_IMX35 #ifdef CONFIG_SOC_IMX35
const struct imx_mxc_rtc_data imx35_mxc_rtc_data __initconst = const struct imx_mxc_rtc_data imx35_mxc_rtc_data __initconst =
imx_mxc_rtc_data_entry_single(MX35); imx_mxc_rtc_data_entry_single(MX35, "imx21-rtc");
#endif /* ifdef CONFIG_SOC_IMX35 */ #endif /* ifdef CONFIG_SOC_IMX35 */
struct platform_device *__init imx_add_mxc_rtc( struct platform_device *__init imx_add_mxc_rtc(
...@@ -40,6 +41,6 @@ struct platform_device *__init imx_add_mxc_rtc( ...@@ -40,6 +41,6 @@ struct platform_device *__init imx_add_mxc_rtc(
}, },
}; };
return imx_add_platform_device("mxc_rtc", -1, return imx_add_platform_device(data->devid, -1,
res, ARRAY_SIZE(res), NULL, 0); res, ARRAY_SIZE(res), NULL, 0);
} }
...@@ -17,8 +17,6 @@ ...@@ -17,8 +17,6 @@
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/clk.h> #include <linux/clk.h>
#include <mach/hardware.h>
#define RTC_INPUT_CLK_32768HZ (0x00 << 5) #define RTC_INPUT_CLK_32768HZ (0x00 << 5)
#define RTC_INPUT_CLK_32000HZ (0x01 << 5) #define RTC_INPUT_CLK_32000HZ (0x01 << 5)
#define RTC_INPUT_CLK_38400HZ (0x02 << 5) #define RTC_INPUT_CLK_38400HZ (0x02 << 5)
...@@ -72,14 +70,38 @@ static const u32 PIE_BIT_DEF[MAX_PIE_NUM][2] = { ...@@ -72,14 +70,38 @@ static const u32 PIE_BIT_DEF[MAX_PIE_NUM][2] = {
#define RTC_TEST2 0x2C /* 32bit rtc test reg 2 */ #define RTC_TEST2 0x2C /* 32bit rtc test reg 2 */
#define RTC_TEST3 0x30 /* 32bit rtc test reg 3 */ #define RTC_TEST3 0x30 /* 32bit rtc test reg 3 */
enum imx_rtc_type {
IMX1_RTC,
IMX21_RTC,
};
struct rtc_plat_data { struct rtc_plat_data {
struct rtc_device *rtc; struct rtc_device *rtc;
void __iomem *ioaddr; void __iomem *ioaddr;
int irq; int irq;
struct clk *clk; struct clk *clk;
struct rtc_time g_rtc_alarm; struct rtc_time g_rtc_alarm;
enum imx_rtc_type devtype;
}; };
static struct platform_device_id imx_rtc_devtype[] = {
{
.name = "imx1-rtc",
.driver_data = IMX1_RTC,
}, {
.name = "imx21-rtc",
.driver_data = IMX21_RTC,
}, {
/* sentinel */
}
};
MODULE_DEVICE_TABLE(platform, imx_rtc_devtype);
static inline int is_imx1_rtc(struct rtc_plat_data *data)
{
return data->devtype == IMX1_RTC;
}
/* /*
* This function is used to obtain the RTC time or the alarm value in * This function is used to obtain the RTC time or the alarm value in
* second. * second.
...@@ -278,10 +300,13 @@ static int mxc_rtc_read_time(struct device *dev, struct rtc_time *tm) ...@@ -278,10 +300,13 @@ static int mxc_rtc_read_time(struct device *dev, struct rtc_time *tm)
*/ */
static int mxc_rtc_set_mmss(struct device *dev, unsigned long time) static int mxc_rtc_set_mmss(struct device *dev, unsigned long time)
{ {
struct platform_device *pdev = to_platform_device(dev);
struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
/* /*
* TTC_DAYR register is 9-bit in MX1 SoC, save time and day of year only * TTC_DAYR register is 9-bit in MX1 SoC, save time and day of year only
*/ */
if (cpu_is_mx1()) { if (is_imx1_rtc(pdata)) {
struct rtc_time tm; struct rtc_time tm;
rtc_time_to_tm(time, &tm); rtc_time_to_tm(time, &tm);
...@@ -360,6 +385,8 @@ static int __devinit mxc_rtc_probe(struct platform_device *pdev) ...@@ -360,6 +385,8 @@ static int __devinit mxc_rtc_probe(struct platform_device *pdev)
if (!pdata) if (!pdata)
return -ENOMEM; return -ENOMEM;
pdata->devtype = pdev->id_entry->driver_data;
if (!devm_request_mem_region(&pdev->dev, res->start, if (!devm_request_mem_region(&pdev->dev, res->start,
resource_size(res), pdev->name)) resource_size(res), pdev->name))
return -EBUSY; return -EBUSY;
...@@ -480,6 +507,7 @@ static struct platform_driver mxc_rtc_driver = { ...@@ -480,6 +507,7 @@ static struct platform_driver mxc_rtc_driver = {
#endif #endif
.owner = THIS_MODULE, .owner = THIS_MODULE,
}, },
.id_table = imx_rtc_devtype,
.probe = mxc_rtc_probe, .probe = mxc_rtc_probe,
.remove = __devexit_p(mxc_rtc_remove), .remove = __devexit_p(mxc_rtc_remove),
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment