Commit c3981365 authored by Tyrel Datwyler's avatar Tyrel Datwyler Committed by Martin K. Petersen

scsi: ibmvfc: fix misdefined reserved field in ibmvfc_fcp_rsp_info

The fcp_rsp_info structure as defined in the FC spec has an initial 3
bytes reserved field. The ibmvfc driver mistakenly defined this field as
4 bytes resulting in the rsp_code field being defined in what should be
the start of the second reserved field and thus always being reported as
zero by the driver.

Ideally, we should wire ibmvfc up with libfc for the sake of code
deduplication, and ease of maintaining standardized structures in a
single place. However, for now simply fixup the definition in ibmvfc for
backporting to distros on older kernels. Wiring up with libfc will be
done in a followup patch.

Cc: <stable@vger.kernel.org>
Reported-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2ce87cc5
...@@ -367,7 +367,7 @@ enum ibmvfc_fcp_rsp_info_codes { ...@@ -367,7 +367,7 @@ enum ibmvfc_fcp_rsp_info_codes {
}; };
struct ibmvfc_fcp_rsp_info { struct ibmvfc_fcp_rsp_info {
__be16 reserved; u8 reserved[3];
u8 rsp_code; u8 rsp_code;
u8 reserved2[4]; u8 reserved2[4];
}__attribute__((packed, aligned (2))); }__attribute__((packed, aligned (2)));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment