Commit c39bbb90 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Tomi Valkeinen

drm: omapdrm: displays: panel-dsi-cm: Fix field access before set

The driver accesses the ddata->in field before it gets set in the
dsicm_connect() function. Use the local in pointer variable instead.

Fixes: 7877632b4cd0 ("drm: omapdrm: displays: Get panel source at connect time")
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 4cba7071
...@@ -778,13 +778,13 @@ static int dsicm_connect(struct omap_dss_device *dssdev) ...@@ -778,13 +778,13 @@ static int dsicm_connect(struct omap_dss_device *dssdev)
goto err_connect; goto err_connect;
} }
r = in->ops.dsi->request_vc(ddata->in, &ddata->channel); r = in->ops.dsi->request_vc(in, &ddata->channel);
if (r) { if (r) {
dev_err(dev, "failed to get virtual channel\n"); dev_err(dev, "failed to get virtual channel\n");
goto err_req_vc; goto err_req_vc;
} }
r = in->ops.dsi->set_vc_id(ddata->in, ddata->channel, TCH); r = in->ops.dsi->set_vc_id(in, ddata->channel, TCH);
if (r) { if (r) {
dev_err(dev, "failed to set VC_ID\n"); dev_err(dev, "failed to set VC_ID\n");
goto err_vc_id; goto err_vc_id;
...@@ -794,7 +794,7 @@ static int dsicm_connect(struct omap_dss_device *dssdev) ...@@ -794,7 +794,7 @@ static int dsicm_connect(struct omap_dss_device *dssdev)
return 0; return 0;
err_vc_id: err_vc_id:
in->ops.dsi->release_vc(ddata->in, ddata->channel); in->ops.dsi->release_vc(in, ddata->channel);
err_req_vc: err_req_vc:
in->ops.dsi->disconnect(in, dssdev); in->ops.dsi->disconnect(in, dssdev);
err_connect: err_connect:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment