Commit c4a52d66 authored by Peteris Rudzusiks's avatar Peteris Rudzusiks Committed by Ben Skeggs

drm/nouveau: fix duplication of nv50_head_atom struct

nv50_head_atomic_duplicate_state() makes a copy of nv50_head_atom
struct. This patch adds copying of struct member named "or", which
previously was left uninitialized in the duplicated structure.

Due to this bug, incorrect nhsync and nvsync values were sometimes used.
In my particular case, that lead to a mismatch between the output
resolution of the graphics device (GeForce GT 630 OEM) and the reported
input signal resolution on the display. xrandr reported 1680x1050, but
the display reported 1280x1024. As a result of this mismatch, the output
on the display looked like it was cropped (only part of the output was
actually visible on the display).

git bisect pointed to commit 2ca7fb5c ("drm/nouveau/kms/nv50: handle
SetControlOutputResource from head"), which added the member "or" to
nv50_head_atom structure, but forgot to copy it in
nv50_head_atomic_duplicate_state().

Fixes: 2ca7fb5c ("drm/nouveau/kms/nv50: handle SetControlOutputResource from head")
Signed-off-by: default avatarPeteris Rudzusiks <peteris.rudzusiks@gmail.com>
Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
parent 13d03e9d
...@@ -413,6 +413,7 @@ nv50_head_atomic_duplicate_state(struct drm_crtc *crtc) ...@@ -413,6 +413,7 @@ nv50_head_atomic_duplicate_state(struct drm_crtc *crtc)
asyh->ovly = armh->ovly; asyh->ovly = armh->ovly;
asyh->dither = armh->dither; asyh->dither = armh->dither;
asyh->procamp = armh->procamp; asyh->procamp = armh->procamp;
asyh->or = armh->or;
asyh->dp = armh->dp; asyh->dp = armh->dp;
asyh->clr.mask = 0; asyh->clr.mask = 0;
asyh->set.mask = 0; asyh->set.mask = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment