Commit c6a32fcb authored by Daniel Vetter's avatar Daniel Vetter

drm/i915: clarify gen2 pageflip cmd

I've reviewed gen2 pageflip code to hunt down multiple prepare pageflip
issues. The only thing I've found is a slight but functionally
meaningless confusion about the length of the mi cmd.

Fix it up and add a comment about what this dword should be (according
to docs at least).
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Signed-Off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 3d29b842
...@@ -7288,7 +7288,7 @@ static int intel_gen2_queue_flip(struct drm_device *dev, ...@@ -7288,7 +7288,7 @@ static int intel_gen2_queue_flip(struct drm_device *dev,
MI_DISPLAY_FLIP_PLANE(intel_crtc->plane)); MI_DISPLAY_FLIP_PLANE(intel_crtc->plane));
OUT_RING(fb->pitches[0]); OUT_RING(fb->pitches[0]);
OUT_RING(obj->gtt_offset + offset); OUT_RING(obj->gtt_offset + offset);
OUT_RING(MI_NOOP); OUT_RING(0); /* aux display base address, unused */
ADVANCE_LP_RING(); ADVANCE_LP_RING();
out: out:
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment