Commit c7b09efa authored by Oleg Drokin's avatar Oleg Drokin Committed by Greg Kroah-Hartman

staging/lustre/llite: Fix integer overflow in ll_fid2path

Reported by Dan Carpenter <dan.carpenter@oracle.com>

outsize = sizeof(*gfout) + gfin->gf_pathlen;

Where outsize is int and gf_pathlen is u32 from userspace
can lead to integer overflowwhere outsize is some small number
less than sizeof(*gfout)

Add a check for pathlen to be of sensical size.
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Reviewed-on: http://review.whamcloud.com/11412
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5476Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: default avatarJohn L. Hammond <john.hammond@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2b358b4e
...@@ -1719,6 +1719,9 @@ int ll_fid2path(struct inode *inode, void __user *arg) ...@@ -1719,6 +1719,9 @@ int ll_fid2path(struct inode *inode, void __user *arg)
if (get_user(pathlen, &gfin->gf_pathlen)) if (get_user(pathlen, &gfin->gf_pathlen))
return -EFAULT; return -EFAULT;
if (pathlen > PATH_MAX)
return -EINVAL;
outsize = sizeof(*gfout) + pathlen; outsize = sizeof(*gfout) + pathlen;
OBD_ALLOC(gfout, outsize); OBD_ALLOC(gfout, outsize);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment