Commit c8119fa8 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller

cxgb4: Use match_string() helper to simplify the code

match_string() returns the array index of a matching string.
Use it instead of the open-coded implementation.
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent caee3174
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
*/ */
#include <linux/sort.h> #include <linux/sort.h>
#include <linux/string.h>
#include "t4_regs.h" #include "t4_regs.h"
#include "cxgb4.h" #include "cxgb4.h"
...@@ -776,24 +777,18 @@ static int cudbg_get_mem_region(struct adapter *padap, ...@@ -776,24 +777,18 @@ static int cudbg_get_mem_region(struct adapter *padap,
struct cudbg_mem_desc *mem_desc) struct cudbg_mem_desc *mem_desc)
{ {
u8 mc, found = 0; u8 mc, found = 0;
u32 i, idx = 0; u32 idx = 0;
int rc; int rc, i;
rc = cudbg_meminfo_get_mem_index(padap, meminfo, mem_type, &mc); rc = cudbg_meminfo_get_mem_index(padap, meminfo, mem_type, &mc);
if (rc) if (rc)
return rc; return rc;
for (i = 0; i < ARRAY_SIZE(cudbg_region); i++) { i = match_string(cudbg_region, ARRAY_SIZE(cudbg_region), region_name);
if (!strcmp(cudbg_region[i], region_name)) { if (i < 0)
found = 1;
idx = i;
break;
}
}
if (!found)
return -EINVAL; return -EINVAL;
found = 0; idx = i;
for (i = 0; i < meminfo->mem_c; i++) { for (i = 0; i < meminfo->mem_c; i++) {
if (meminfo->mem[i].idx >= ARRAY_SIZE(cudbg_region)) if (meminfo->mem[i].idx >= ARRAY_SIZE(cudbg_region))
continue; /* Skip holes */ continue; /* Skip holes */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment