Commit c994611a authored by Hans de Goede's avatar Hans de Goede Committed by Darren Hart (VMware)

platform/x86: asus-wmi: Allow loading on systems without the Asus Management GUID

hid-asus depends on asus-wmi through the asus_wmi_evaluate_method. Before
this commit asus-wmi, and thus hid-asus, could not be loaded on non-Asus
systems. This breaks using Asus bluetooth keyboards such as the Asus
T100CHI keyboard with non Asus systems.

This commit fixes this by allowing asus-wmi to load on systems without the
Asus Management GUID.

This is safe to do since all asus-wmi sub drivers use
asus_wmi_register_driver which also checks for the GUID.

This commit also improves the error messages in asus_wmi_register_driver
to include "ASUS" in their description to make them more clear. This is
important since we now rely on those errors when loaded on systems without
the Asus Management GUID.
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 2a13096a
...@@ -2265,12 +2265,12 @@ static int asus_wmi_probe(struct platform_device *pdev) ...@@ -2265,12 +2265,12 @@ static int asus_wmi_probe(struct platform_device *pdev)
int ret; int ret;
if (!wmi_has_guid(ASUS_WMI_MGMT_GUID)) { if (!wmi_has_guid(ASUS_WMI_MGMT_GUID)) {
pr_warn("Management GUID not found\n"); pr_warn("ASUS Management GUID not found\n");
return -ENODEV; return -ENODEV;
} }
if (wdrv->event_guid && !wmi_has_guid(wdrv->event_guid)) { if (wdrv->event_guid && !wmi_has_guid(wdrv->event_guid)) {
pr_warn("Event GUID not found\n"); pr_warn("ASUS Event GUID not found\n");
return -ENODEV; return -ENODEV;
} }
...@@ -2320,11 +2320,6 @@ EXPORT_SYMBOL_GPL(asus_wmi_unregister_driver); ...@@ -2320,11 +2320,6 @@ EXPORT_SYMBOL_GPL(asus_wmi_unregister_driver);
static int __init asus_wmi_init(void) static int __init asus_wmi_init(void)
{ {
if (!wmi_has_guid(ASUS_WMI_MGMT_GUID)) {
pr_info("Asus Management GUID not found\n");
return -ENODEV;
}
pr_info("ASUS WMI generic driver loaded\n"); pr_info("ASUS WMI generic driver loaded\n");
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment