Skip to content

L
linux
Commit c9ab760d authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files
Options

staging: comedi: addi-data: remove special handling for apci1710 

Now that the addi_apci_1710 driver is not using addi_common.c we can
remove the CONFIG_APCI_1710 define and all the special handling for
the initialization of it's subdevices.

Also remove the i_ADDIDATA_InsnReadEeprom() function from the
addi_apci_1710 driver. This board does not have an eeprom subdevice
and does not use this function.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 10db292f
Hide whitespace changes
Inline Side-by-side
Showing with 137 additions and 315 deletions
drivers/staging/comedi/drivers/addi-data/addi_common.c
View file @ c9ab760d
...@@ -212,158 +212,149 @@ static int addi_attach_pci(struct comedi_device *dev, ...@@ -212,158 +212,149 @@ static int addi_attach_pci(struct comedi_device *dev,
} }
} }
if (!strcmp(dev->board_name, "apci1710")) { n_subdevices = 7;
#ifdef CONFIG_APCI_1710 ret = comedi_alloc_subdevices(dev, n_subdevices);
i_ADDI_AttachPCI1710(dev); if (ret)
return ret;
/* save base address */ /* Allocate and Initialise AI Subdevice Structures */
devpriv->s_BoardInfos.ui_Address = pci_resource_start(pcidev, 2); s = &dev->subdevices[0];
#endif if ((devpriv->s_EeParameters.i_NbrAiChannel)
} else { || (this_board->i_NbrAiChannelDiff)) {
n_subdevices = 7; dev->read_subdev = s;
ret = comedi_alloc_subdevices(dev, n_subdevices); s->type = COMEDI_SUBD_AI;
if (ret) s->subdev_flags =
return ret; SDF_READABLE | SDF_COMMON | SDF_GROUND
| SDF_DIFF;
/* Allocate and Initialise AI Subdevice Structures */ if (devpriv->s_EeParameters.i_NbrAiChannel) {
s = &dev->subdevices[0]; s->n_chan =
if ((devpriv->s_EeParameters.i_NbrAiChannel) devpriv->s_EeParameters.i_NbrAiChannel;
|| (this_board->i_NbrAiChannelDiff)) { devpriv->b_SingelDiff = 0;
dev->read_subdev = s; } else {
s->type = COMEDI_SUBD_AI; s->n_chan = this_board->i_NbrAiChannelDiff;
s->subdev_flags = devpriv->b_SingelDiff = 1;
SDF_READABLE | SDF_COMMON | SDF_GROUND }
| SDF_DIFF; s->maxdata = devpriv->s_EeParameters.i_AiMaxdata;
if (devpriv->s_EeParameters.i_NbrAiChannel) { s->len_chanlist = this_board->i_AiChannelList;
s->n_chan = s->range_table = this_board->pr_AiRangelist;
devpriv->s_EeParameters.i_NbrAiChannel;
devpriv->b_SingelDiff = 0;
} else {
s->n_chan = this_board->i_NbrAiChannelDiff;
devpriv->b_SingelDiff = 1;
}
s->maxdata = devpriv->s_EeParameters.i_AiMaxdata;
s->len_chanlist = this_board->i_AiChannelList;
s->range_table = this_board->pr_AiRangelist;
/* Set the initialisation flag */ /* Set the initialisation flag */
devpriv->b_AiInitialisation = 1; devpriv->b_AiInitialisation = 1;
s->insn_config = this_board->ai_config; s->insn_config = this_board->ai_config;
s->insn_read = this_board->ai_read; s->insn_read = this_board->ai_read;
s->insn_write = this_board->ai_write; s->insn_write = this_board->ai_write;
s->insn_bits = this_board->ai_bits; s->insn_bits = this_board->ai_bits;
s->do_cmdtest = this_board->ai_cmdtest; s->do_cmdtest = this_board->ai_cmdtest;
s->do_cmd = this_board->ai_cmd; s->do_cmd = this_board->ai_cmd;
s->cancel = this_board->ai_cancel; s->cancel = this_board->ai_cancel;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
} }
/* Allocate and Initialise AO Subdevice Structures */ /* Allocate and Initialise AO Subdevice Structures */
s = &dev->subdevices[1]; s = &dev->subdevices[1];
if (devpriv->s_EeParameters.i_NbrAoChannel) { if (devpriv->s_EeParameters.i_NbrAoChannel) {
s->type = COMEDI_SUBD_AO; s->type = COMEDI_SUBD_AO;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = devpriv->s_EeParameters.i_NbrAoChannel; s->n_chan = devpriv->s_EeParameters.i_NbrAoChannel;
s->maxdata = devpriv->s_EeParameters.i_AoMaxdata; s->maxdata = devpriv->s_EeParameters.i_AoMaxdata;
s->len_chanlist = s->len_chanlist =
devpriv->s_EeParameters.i_NbrAoChannel; devpriv->s_EeParameters.i_NbrAoChannel;
s->range_table = this_board->pr_AoRangelist; s->range_table = this_board->pr_AoRangelist;
s->insn_config = this_board->ao_config; s->insn_config = this_board->ao_config;
s->insn_write = this_board->ao_write; s->insn_write = this_board->ao_write;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
} }
/* Allocate and Initialise DI Subdevice Structures */ /* Allocate and Initialise DI Subdevice Structures */
s = &dev->subdevices[2]; s = &dev->subdevices[2];
if (devpriv->s_EeParameters.i_NbrDiChannel) { if (devpriv->s_EeParameters.i_NbrDiChannel) {
s->type = COMEDI_SUBD_DI; s->type = COMEDI_SUBD_DI;
s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_COMMON; s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = devpriv->s_EeParameters.i_NbrDiChannel; s->n_chan = devpriv->s_EeParameters.i_NbrDiChannel;
s->maxdata = 1; s->maxdata = 1;
s->len_chanlist = s->len_chanlist =
devpriv->s_EeParameters.i_NbrDiChannel; devpriv->s_EeParameters.i_NbrDiChannel;
s->range_table = &range_digital; s->range_table = &range_digital;
s->io_bits = 0; /* all bits input */ s->io_bits = 0; /* all bits input */
s->insn_config = this_board->di_config; s->insn_config = this_board->di_config;
s->insn_read = this_board->di_read; s->insn_read = this_board->di_read;
s->insn_write = this_board->di_write; s->insn_write = this_board->di_write;
s->insn_bits = this_board->di_bits; s->insn_bits = this_board->di_bits;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
} }
/* Allocate and Initialise DO Subdevice Structures */ /* Allocate and Initialise DO Subdevice Structures */
s = &dev->subdevices[3]; s = &dev->subdevices[3];
if (devpriv->s_EeParameters.i_NbrDoChannel) { if (devpriv->s_EeParameters.i_NbrDoChannel) {
s->type = COMEDI_SUBD_DO; s->type = COMEDI_SUBD_DO;
s->subdev_flags = s->subdev_flags =
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = devpriv->s_EeParameters.i_NbrDoChannel; s->n_chan = devpriv->s_EeParameters.i_NbrDoChannel;
s->maxdata = devpriv->s_EeParameters.i_DoMaxdata; s->maxdata = devpriv->s_EeParameters.i_DoMaxdata;
s->len_chanlist = s->len_chanlist =
devpriv->s_EeParameters.i_NbrDoChannel; devpriv->s_EeParameters.i_NbrDoChannel;
s->range_table = &range_digital; s->range_table = &range_digital;
s->io_bits = 0xf; /* all bits output */ s->io_bits = 0xf; /* all bits output */
/* insn_config - for digital output memory */ /* insn_config - for digital output memory */
s->insn_config = this_board->do_config; s->insn_config = this_board->do_config;
s->insn_write = this_board->do_write; s->insn_write = this_board->do_write;
s->insn_bits = this_board->do_bits; s->insn_bits = this_board->do_bits;
s->insn_read = this_board->do_read; s->insn_read = this_board->do_read;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
} }
/* Allocate and Initialise Timer Subdevice Structures */ /* Allocate and Initialise Timer Subdevice Structures */
s = &dev->subdevices[4]; s = &dev->subdevices[4];
if (devpriv->s_EeParameters.i_Timer) { if (devpriv->s_EeParameters.i_Timer) {
s->type = COMEDI_SUBD_TIMER; s->type = COMEDI_SUBD_TIMER;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON; s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = 1; s->n_chan = 1;
s->maxdata = 0; s->maxdata = 0;
s->len_chanlist = 1; s->len_chanlist = 1;
s->range_table = &range_digital; s->range_table = &range_digital;
s->insn_write = this_board->timer_write; s->insn_write = this_board->timer_write;
s->insn_read = this_board->timer_read; s->insn_read = this_board->timer_read;
s->insn_config = this_board->timer_config; s->insn_config = this_board->timer_config;
s->insn_bits = this_board->timer_bits; s->insn_bits = this_board->timer_bits;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
} }
/* Allocate and Initialise TTL */ /* Allocate and Initialise TTL */
s = &dev->subdevices[5]; s = &dev->subdevices[5];
if (this_board->i_NbrTTLChannel) { if (this_board->i_NbrTTLChannel) {
s->type = COMEDI_SUBD_TTLIO; s->type = COMEDI_SUBD_TTLIO;
s->subdev_flags = s->subdev_flags =
SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON; SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = this_board->i_NbrTTLChannel; s->n_chan = this_board->i_NbrTTLChannel;
s->maxdata = 1; s->maxdata = 1;
s->io_bits = 0; /* all bits input */ s->io_bits = 0; /* all bits input */
s->len_chanlist = this_board->i_NbrTTLChannel; s->len_chanlist = this_board->i_NbrTTLChannel;
s->range_table = &range_digital; s->range_table = &range_digital;
s->insn_config = this_board->ttl_config; s->insn_config = this_board->ttl_config;
s->insn_bits = this_board->ttl_bits; s->insn_bits = this_board->ttl_bits;
s->insn_read = this_board->ttl_read; s->insn_read = this_board->ttl_read;
s->insn_write = this_board->ttl_write; s->insn_write = this_board->ttl_write;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
} }
/* EEPROM */ /* EEPROM */
s = &dev->subdevices[6]; s = &dev->subdevices[6];
if (this_board->i_PCIEeprom) { if (this_board->i_PCIEeprom) {
s->type = COMEDI_SUBD_MEMORY; s->type = COMEDI_SUBD_MEMORY;
s->subdev_flags = SDF_READABLE | SDF_INTERNAL; s->subdev_flags = SDF_READABLE | SDF_INTERNAL;
s->n_chan = 256; s->n_chan = 256;
s->maxdata = 0xffff; s->maxdata = 0xffff;
s->insn_read = i_ADDIDATA_InsnReadEeprom; s->insn_read = i_ADDIDATA_InsnReadEeprom;
} else { } else {
s->type = COMEDI_SUBD_UNUSED; s->type = COMEDI_SUBD_UNUSED;
}
} }
i_ADDI_Reset(dev); i_ADDI_Reset(dev);
......
drivers/staging/comedi/drivers/addi_apci_1710.c
View file @ c9ab760d
...@@ -16,8 +16,6 @@ static void fpu_end(void) ...@@ -16,8 +16,6 @@ static void fpu_end(void)
kernel_fpu_end(); kernel_fpu_end();
} }
#define CONFIG_APCI_1710 1
#include "addi-data/addi_eeprom.c" #include "addi-data/addi_eeprom.c"
#include "addi-data/hwdrv_APCI1710.c" #include "addi-data/hwdrv_APCI1710.c"
...@@ -39,23 +37,6 @@ static const struct addi_board apci1710_boardtypes[] = { ...@@ -39,23 +37,6 @@ static const struct addi_board apci1710_boardtypes[] = {
}, },
}; };
static int i_ADDIDATA_InsnReadEeprom(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn,
unsigned int *data)
{
const struct addi_board *this_board = comedi_board(dev);
struct addi_private *devpriv = dev->private;
unsigned short w_Address = CR_CHAN(insn->chanspec);
unsigned short w_Data;
w_Data = addi_eeprom_readw(devpriv->i_IobaseAmcc,
this_board->pc_EepromChip, 2 * w_Address);
data[0] = w_Data;
return insn->n;
}
static irqreturn_t v_ADDI_Interrupt(int irq, void *d) static irqreturn_t v_ADDI_Interrupt(int irq, void *d)
{ {
struct comedi_device *dev = d; struct comedi_device *dev = d;
...@@ -209,159 +190,9 @@ static int apci1710_attach_pci(struct comedi_device *dev, ...@@ -209,159 +190,9 @@ static int apci1710_attach_pci(struct comedi_device *dev,
} }
} }
if (!strcmp(dev->board_name, "apci1710")) { i_ADDI_AttachPCI1710(dev);
#ifdef CONFIG_APCI_1710
i_ADDI_AttachPCI1710(dev);
/* save base address */
devpriv->s_BoardInfos.ui_Address = pci_resource_start(pcidev, 2);
#endif
} else {
n_subdevices = 7;
ret = comedi_alloc_subdevices(dev, n_subdevices);
if (ret)
return ret;
/* Allocate and Initialise AI Subdevice Structures */
s = &dev->subdevices[0];
if ((devpriv->s_EeParameters.i_NbrAiChannel)
|| (this_board->i_NbrAiChannelDiff)) {
dev->read_subdev = s;
s->type = COMEDI_SUBD_AI;
s->subdev_flags =
SDF_READABLE | SDF_COMMON | SDF_GROUND
| SDF_DIFF;
if (devpriv->s_EeParameters.i_NbrAiChannel) {
s->n_chan =
devpriv->s_EeParameters.i_NbrAiChannel;
devpriv->b_SingelDiff = 0;
} else {
s->n_chan = this_board->i_NbrAiChannelDiff;
devpriv->b_SingelDiff = 1;
}
s->maxdata = devpriv->s_EeParameters.i_AiMaxdata;
s->len_chanlist = this_board->i_AiChannelList;
s->range_table = this_board->pr_AiRangelist;
/* Set the initialisation flag */
devpriv->b_AiInitialisation = 1;
s->insn_config = this_board->ai_config;
s->insn_read = this_board->ai_read;
s->insn_write = this_board->ai_write;
s->insn_bits = this_board->ai_bits;
s->do_cmdtest = this_board->ai_cmdtest;
s->do_cmd = this_board->ai_cmd;
s->cancel = this_board->ai_cancel;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
/* Allocate and Initialise AO Subdevice Structures */
s = &dev->subdevices[1];
if (devpriv->s_EeParameters.i_NbrAoChannel) {
s->type = COMEDI_SUBD_AO;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = devpriv->s_EeParameters.i_NbrAoChannel;
s->maxdata = devpriv->s_EeParameters.i_AoMaxdata;
s->len_chanlist =
devpriv->s_EeParameters.i_NbrAoChannel;
s->range_table = this_board->pr_AoRangelist;
s->insn_config = this_board->ao_config;
s->insn_write = this_board->ao_write;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
/* Allocate and Initialise DI Subdevice Structures */
s = &dev->subdevices[2];
if (devpriv->s_EeParameters.i_NbrDiChannel) {
s->type = COMEDI_SUBD_DI;
s->subdev_flags = SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = devpriv->s_EeParameters.i_NbrDiChannel;
s->maxdata = 1;
s->len_chanlist =
devpriv->s_EeParameters.i_NbrDiChannel;
s->range_table = &range_digital;
s->io_bits = 0; /* all bits input */
s->insn_config = this_board->di_config;
s->insn_read = this_board->di_read;
s->insn_write = this_board->di_write;
s->insn_bits = this_board->di_bits;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
/* Allocate and Initialise DO Subdevice Structures */
s = &dev->subdevices[3];
if (devpriv->s_EeParameters.i_NbrDoChannel) {
s->type = COMEDI_SUBD_DO;
s->subdev_flags =
SDF_READABLE | SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = devpriv->s_EeParameters.i_NbrDoChannel;
s->maxdata = devpriv->s_EeParameters.i_DoMaxdata;
s->len_chanlist =
devpriv->s_EeParameters.i_NbrDoChannel;
s->range_table = &range_digital;
s->io_bits = 0xf; /* all bits output */
/* insn_config - for digital output memory */
s->insn_config = this_board->do_config;
s->insn_write = this_board->do_write;
s->insn_bits = this_board->do_bits;
s->insn_read = this_board->do_read;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
/* Allocate and Initialise Timer Subdevice Structures */ devpriv->s_BoardInfos.ui_Address = pci_resource_start(pcidev, 2);
s = &dev->subdevices[4];
if (devpriv->s_EeParameters.i_Timer) {
s->type = COMEDI_SUBD_TIMER;
s->subdev_flags = SDF_WRITEABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = 1;
s->maxdata = 0;
s->len_chanlist = 1;
s->range_table = &range_digital;
s->insn_write = this_board->timer_write;
s->insn_read = this_board->timer_read;
s->insn_config = this_board->timer_config;
s->insn_bits = this_board->timer_bits;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
/* Allocate and Initialise TTL */
s = &dev->subdevices[5];
if (this_board->i_NbrTTLChannel) {
s->type = COMEDI_SUBD_TTLIO;
s->subdev_flags =
SDF_WRITEABLE | SDF_READABLE | SDF_GROUND | SDF_COMMON;
s->n_chan = this_board->i_NbrTTLChannel;
s->maxdata = 1;
s->io_bits = 0; /* all bits input */
s->len_chanlist = this_board->i_NbrTTLChannel;
s->range_table = &range_digital;
s->insn_config = this_board->ttl_config;
s->insn_bits = this_board->ttl_bits;
s->insn_read = this_board->ttl_read;
s->insn_write = this_board->ttl_write;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
/* EEPROM */
s = &dev->subdevices[6];
if (this_board->i_PCIEeprom) {
s->type = COMEDI_SUBD_MEMORY;
s->subdev_flags = SDF_READABLE | SDF_INTERNAL;
s->n_chan = 256;
s->maxdata = 0xffff;
s->insn_read = i_ADDIDATA_InsnReadEeprom;
} else {
s->type = COMEDI_SUBD_UNUSED;
}
}
i_ADDI_Reset(dev); i_ADDI_Reset(dev);
return 0; return 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7