Commit cafb3abe authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Dmitry Torokhov

Input: sun4i-ps2 - fix handling of platform_get_irq() error

platform_get_irq() returns -ERRNO on error.  In such case comparison
to 0 would pass the check.

Fixes: e443631d ("Input: serio - add support for Alwinner A10/A20 PS/2 controller")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: default avatarChen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20200828145744.3636-4-krzk@kernel.orgSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent c277e1f0
...@@ -211,7 +211,6 @@ static int sun4i_ps2_probe(struct platform_device *pdev) ...@@ -211,7 +211,6 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
struct sun4i_ps2data *drvdata; struct sun4i_ps2data *drvdata;
struct serio *serio; struct serio *serio;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
unsigned int irq;
int error; int error;
drvdata = kzalloc(sizeof(struct sun4i_ps2data), GFP_KERNEL); drvdata = kzalloc(sizeof(struct sun4i_ps2data), GFP_KERNEL);
...@@ -264,14 +263,12 @@ static int sun4i_ps2_probe(struct platform_device *pdev) ...@@ -264,14 +263,12 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
writel(0, drvdata->reg_base + PS2_REG_GCTL); writel(0, drvdata->reg_base + PS2_REG_GCTL);
/* Get IRQ for the device */ /* Get IRQ for the device */
irq = platform_get_irq(pdev, 0); drvdata->irq = platform_get_irq(pdev, 0);
if (!irq) { if (drvdata->irq < 0) {
dev_err(dev, "no IRQ found\n"); error = drvdata->irq;
error = -ENXIO;
goto err_disable_clk; goto err_disable_clk;
} }
drvdata->irq = irq;
drvdata->serio = serio; drvdata->serio = serio;
drvdata->dev = dev; drvdata->dev = dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment