Commit ce9f6506 authored by Venu Byravarasu's avatar Venu Byravarasu Committed by Linus Torvalds

drivers/rtc/rtc-twl.c: optimize IRQ bit access

As the TWL RTC driver has a cached copy of enabled RTC interrupt bits in
variable rtc_irq_bits, that can be checked before really setting or
masking any of the interrupt bits.
Signed-off-by: default avatarVenu Byravarasu <vbyravarasu@nvidia.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b4f0b880
...@@ -176,6 +176,10 @@ static int set_rtc_irq_bit(unsigned char bit) ...@@ -176,6 +176,10 @@ static int set_rtc_irq_bit(unsigned char bit)
unsigned char val; unsigned char val;
int ret; int ret;
/* if the bit is set, return from here */
if (rtc_irq_bits & bit)
return 0;
val = rtc_irq_bits | bit; val = rtc_irq_bits | bit;
val &= ~BIT_RTC_INTERRUPTS_REG_EVERY_M; val &= ~BIT_RTC_INTERRUPTS_REG_EVERY_M;
ret = twl_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG); ret = twl_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG);
...@@ -193,6 +197,10 @@ static int mask_rtc_irq_bit(unsigned char bit) ...@@ -193,6 +197,10 @@ static int mask_rtc_irq_bit(unsigned char bit)
unsigned char val; unsigned char val;
int ret; int ret;
/* if the bit is clear, return from here */
if (!(rtc_irq_bits & bit))
return 0;
val = rtc_irq_bits & ~bit; val = rtc_irq_bits & ~bit;
ret = twl_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG); ret = twl_rtc_write_u8(val, REG_RTC_INTERRUPTS_REG);
if (ret == 0) if (ret == 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment