Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
linux
Commits
d6ac02df
Commit
d6ac02df
authored
Jul 19, 2007
by
Trond Myklebust
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
NFSv4: Fix the readdir reply buffer alignment
Signed-off-by:
Trond Myklebust
<
Trond.Myklebust@netapp.com
>
parent
9104a55d
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
13 deletions
+14
-13
fs/nfs/nfs4xdr.c
fs/nfs/nfs4xdr.c
+14
-13
No files found.
fs/nfs/nfs4xdr.c
View file @
d6ac02df
...
...
@@ -1168,12 +1168,10 @@ static int encode_read(struct xdr_stream *xdr, const struct nfs_readargs *args)
static
int
encode_readdir
(
struct
xdr_stream
*
xdr
,
const
struct
nfs4_readdir_arg
*
readdir
,
struct
rpc_rqst
*
req
)
{
struct
rpc_auth
*
auth
=
req
->
rq_task
->
tk_msg
.
rpc_cred
->
cr_auth
;
uint32_t
attrs
[
2
]
=
{
FATTR4_WORD0_RDATTR_ERROR
|
FATTR4_WORD0_FILEID
,
FATTR4_WORD1_MOUNTED_ON_FILEID
,
};
int
replen
;
__be32
*
p
;
RESERVE_SPACE
(
12
+
NFS4_VERIFIER_SIZE
+
20
);
...
...
@@ -1198,17 +1196,6 @@ static int encode_readdir(struct xdr_stream *xdr, const struct nfs4_readdir_arg
attrs
[
0
]
&
readdir
->
bitmask
[
0
],
attrs
[
1
]
&
readdir
->
bitmask
[
1
]);
/* set up reply kvec
* toplevel_status + taglen + rescount + OP_PUTFH + status
* + OP_READDIR + status + verifer(2) = 9
*/
replen
=
(
RPC_REPHDRSIZE
+
auth
->
au_rslack
+
9
)
<<
2
;
xdr_inline_pages
(
&
req
->
rq_rcv_buf
,
replen
,
readdir
->
pages
,
readdir
->
pgbase
,
readdir
->
count
);
dprintk
(
"%s: inlined page args = (%u, %p, %u, %u)
\n
"
,
__FUNCTION__
,
replen
,
readdir
->
pages
,
readdir
->
pgbase
,
readdir
->
count
);
return
0
;
}
...
...
@@ -1815,6 +1802,8 @@ static int nfs4_xdr_enc_readdir(struct rpc_rqst *req, __be32 *p, const struct nf
struct
compound_hdr
hdr
=
{
.
nops
=
2
,
};
struct
rpc_auth
*
auth
=
req
->
rq_task
->
tk_msg
.
rpc_cred
->
cr_auth
;
int
replen
;
int
status
;
xdr_init_encode
(
&
xdr
,
&
req
->
rq_snd_buf
,
p
);
...
...
@@ -1823,6 +1812,18 @@ static int nfs4_xdr_enc_readdir(struct rpc_rqst *req, __be32 *p, const struct nf
if
(
status
)
goto
out
;
status
=
encode_readdir
(
&
xdr
,
args
,
req
);
/* set up reply kvec
* toplevel_status + taglen + rescount + OP_PUTFH + status
* + OP_READDIR + status + verifer(2) = 9
*/
replen
=
(
RPC_REPHDRSIZE
+
auth
->
au_rslack
+
NFS4_dec_readdir_sz
)
<<
2
;
xdr_inline_pages
(
&
req
->
rq_rcv_buf
,
replen
,
args
->
pages
,
args
->
pgbase
,
args
->
count
);
dprintk
(
"%s: inlined page args = (%u, %p, %u, %u)
\n
"
,
__FUNCTION__
,
replen
,
args
->
pages
,
args
->
pgbase
,
args
->
count
);
out:
return
status
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment