Commit d8d841e8 authored by Mathieu OTHACEHE's avatar Mathieu OTHACEHE Committed by Johan Hovold

USB: serial: ti_usb_3410_5052: use functions rather than macros

Functions are preferable to macros resembling functions.
Signed-off-by: default avatarMathieu OTHACEHE <m.othacehe@gmail.com>
[johan: drop inline keyword, move above calling function ]
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 4ab0e0da
...@@ -248,8 +248,6 @@ struct ti_interrupt { ...@@ -248,8 +248,6 @@ struct ti_interrupt {
} __packed; } __packed;
/* Interrupt codes */ /* Interrupt codes */
#define TI_GET_PORT_FROM_CODE(c) (((c) >> 4) - 3)
#define TI_GET_FUNC_FROM_CODE(c) ((c) & 0x0f)
#define TI_CODE_HARDWARE_ERROR 0xFF #define TI_CODE_HARDWARE_ERROR 0xFF
#define TI_CODE_DATA_ERROR 0x03 #define TI_CODE_DATA_ERROR 0x03
#define TI_CODE_MODEM_STATUS 0x04 #define TI_CODE_MODEM_STATUS 0x04
...@@ -1168,6 +1166,15 @@ static void ti_break(struct tty_struct *tty, int break_state) ...@@ -1168,6 +1166,15 @@ static void ti_break(struct tty_struct *tty, int break_state)
dev_dbg(&port->dev, "%s - error setting break, %d\n", __func__, status); dev_dbg(&port->dev, "%s - error setting break, %d\n", __func__, status);
} }
static int ti_get_port_from_code(unsigned char code)
{
return (code >> 4) - 3;
}
static int ti_get_func_from_code(unsigned char code)
{
return code & 0x0f;
}
static void ti_interrupt_callback(struct urb *urb) static void ti_interrupt_callback(struct urb *urb)
{ {
...@@ -1209,8 +1216,8 @@ static void ti_interrupt_callback(struct urb *urb) ...@@ -1209,8 +1216,8 @@ static void ti_interrupt_callback(struct urb *urb)
goto exit; goto exit;
} }
port_number = TI_GET_PORT_FROM_CODE(data[0]); port_number = ti_get_port_from_code(data[0]);
function = TI_GET_FUNC_FROM_CODE(data[0]); function = ti_get_func_from_code(data[0]);
dev_dbg(dev, "%s - port_number %d, function %d, data 0x%02X\n", dev_dbg(dev, "%s - port_number %d, function %d, data 0x%02X\n",
__func__, port_number, function, data[1]); __func__, port_number, function, data[1]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment