Commit d8ea6cf8 authored by vignesh babu's avatar vignesh babu Committed by Linus Torvalds

ext2/4: use is_power_of_2()

Replace n & (n - 1) with is_power_of_2(n)
Signed-off-by: default avatarvignesh babu <vignesh.babu@wipro.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3befe7ce
...@@ -30,6 +30,7 @@ ...@@ -30,6 +30,7 @@
#include <linux/vfs.h> #include <linux/vfs.h>
#include <linux/seq_file.h> #include <linux/seq_file.h>
#include <linux/mount.h> #include <linux/mount.h>
#include <linux/log2.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include "ext2.h" #include "ext2.h"
#include "xattr.h" #include "xattr.h"
...@@ -862,7 +863,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) ...@@ -862,7 +863,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
sbi->s_inode_size = le16_to_cpu(es->s_inode_size); sbi->s_inode_size = le16_to_cpu(es->s_inode_size);
sbi->s_first_ino = le32_to_cpu(es->s_first_ino); sbi->s_first_ino = le32_to_cpu(es->s_first_ino);
if ((sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE) || if ((sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE) ||
(sbi->s_inode_size & (sbi->s_inode_size - 1)) || !is_power_of_2(sbi->s_inode_size) ||
(sbi->s_inode_size > blocksize)) { (sbi->s_inode_size > blocksize)) {
printk ("EXT2-fs: unsupported inode size: %d\n", printk ("EXT2-fs: unsupported inode size: %d\n",
sbi->s_inode_size); sbi->s_inode_size);
......
...@@ -1738,7 +1738,7 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent) ...@@ -1738,7 +1738,7 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent)
if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_64BIT)) { if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_64BIT)) {
if (sbi->s_desc_size < EXT4_MIN_DESC_SIZE_64BIT || if (sbi->s_desc_size < EXT4_MIN_DESC_SIZE_64BIT ||
sbi->s_desc_size > EXT4_MAX_DESC_SIZE || sbi->s_desc_size > EXT4_MAX_DESC_SIZE ||
sbi->s_desc_size & (sbi->s_desc_size - 1)) { !is_power_of_2(sbi->s_desc_size)) {
printk(KERN_ERR printk(KERN_ERR
"EXT4-fs: unsupported descriptor size %lu\n", "EXT4-fs: unsupported descriptor size %lu\n",
sbi->s_desc_size); sbi->s_desc_size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment