Commit d952d69e authored by Dmitry Monakhov's avatar Dmitry Monakhov Committed by Theodore Ts'o

ext4: ext4_inline_data_fiemap should respect callers argument

Currently ext4_inline_data_fiemap ignores requested arguments (start
and len) which may lead endless loop if start != 0.  Also fix incorrect
extent length determination.
Signed-off-by: default avatarDmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 5cc28a9e
...@@ -2634,7 +2634,7 @@ extern struct buffer_head *ext4_get_first_inline_block(struct inode *inode, ...@@ -2634,7 +2634,7 @@ extern struct buffer_head *ext4_get_first_inline_block(struct inode *inode,
int *retval); int *retval);
extern int ext4_inline_data_fiemap(struct inode *inode, extern int ext4_inline_data_fiemap(struct inode *inode,
struct fiemap_extent_info *fieinfo, struct fiemap_extent_info *fieinfo,
int *has_inline); int *has_inline, __u64 start, __u64 len);
extern int ext4_try_to_evict_inline_data(handle_t *handle, extern int ext4_try_to_evict_inline_data(handle_t *handle,
struct inode *inode, struct inode *inode,
int needed); int needed);
......
...@@ -5151,7 +5151,8 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, ...@@ -5151,7 +5151,8 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
if (ext4_has_inline_data(inode)) { if (ext4_has_inline_data(inode)) {
int has_inline = 1; int has_inline = 1;
error = ext4_inline_data_fiemap(inode, fieinfo, &has_inline); error = ext4_inline_data_fiemap(inode, fieinfo, &has_inline,
start, len);
if (has_inline) if (has_inline)
return error; return error;
......
...@@ -1808,11 +1808,12 @@ int ext4_destroy_inline_data(handle_t *handle, struct inode *inode) ...@@ -1808,11 +1808,12 @@ int ext4_destroy_inline_data(handle_t *handle, struct inode *inode)
int ext4_inline_data_fiemap(struct inode *inode, int ext4_inline_data_fiemap(struct inode *inode,
struct fiemap_extent_info *fieinfo, struct fiemap_extent_info *fieinfo,
int *has_inline) int *has_inline, __u64 start, __u64 len)
{ {
__u64 physical = 0; __u64 physical = 0;
__u64 length; __u64 inline_len;
__u32 flags = FIEMAP_EXTENT_DATA_INLINE | FIEMAP_EXTENT_LAST; __u32 flags = FIEMAP_EXTENT_DATA_INLINE | FIEMAP_EXTENT_NOT_ALIGNED |
FIEMAP_EXTENT_LAST;
int error = 0; int error = 0;
struct ext4_iloc iloc; struct ext4_iloc iloc;
...@@ -1821,6 +1822,13 @@ int ext4_inline_data_fiemap(struct inode *inode, ...@@ -1821,6 +1822,13 @@ int ext4_inline_data_fiemap(struct inode *inode,
*has_inline = 0; *has_inline = 0;
goto out; goto out;
} }
inline_len = min_t(size_t, ext4_get_inline_size(inode),
i_size_read(inode));
if (start >= inline_len)
goto out;
if (start + len < inline_len)
inline_len = start + len;
inline_len -= start;
error = ext4_get_inode_loc(inode, &iloc); error = ext4_get_inode_loc(inode, &iloc);
if (error) if (error)
...@@ -1829,11 +1837,10 @@ int ext4_inline_data_fiemap(struct inode *inode, ...@@ -1829,11 +1837,10 @@ int ext4_inline_data_fiemap(struct inode *inode,
physical = (__u64)iloc.bh->b_blocknr << inode->i_sb->s_blocksize_bits; physical = (__u64)iloc.bh->b_blocknr << inode->i_sb->s_blocksize_bits;
physical += (char *)ext4_raw_inode(&iloc) - iloc.bh->b_data; physical += (char *)ext4_raw_inode(&iloc) - iloc.bh->b_data;
physical += offsetof(struct ext4_inode, i_block); physical += offsetof(struct ext4_inode, i_block);
length = i_size_read(inode);
if (physical) if (physical)
error = fiemap_fill_next_extent(fieinfo, 0, physical, error = fiemap_fill_next_extent(fieinfo, start, physical,
length, flags); inline_len, flags);
brelse(iloc.bh); brelse(iloc.bh);
out: out:
up_read(&EXT4_I(inode)->xattr_sem); up_read(&EXT4_I(inode)->xattr_sem);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment