Commit dabc5ec9 authored by Roman Bolshakov's avatar Roman Bolshakov Committed by Martin K. Petersen

scsi: qla2xxx: Don't defer relogin unconditonally

qla2x00_configure_local_loop sets RELOGIN_NEEDED bit and calls
qla24xx_fcport_handle_login to perform the login. This bit triggers a wake
up of DPC later after a successful login.

The deferred call is not needed if login succeeds, and it's set in
qla24xx_fcport_handle_login in case of errors, hence it should be safe to
drop.

Link: https://lore.kernel.org/r/20191125165702.1013-12-r.bolshakov@yadro.comAcked-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Acked-by: default avatarQuinn Tran <qutran@marvell.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Tested-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarRoman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5e6b01d8
...@@ -5054,7 +5054,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha) ...@@ -5054,7 +5054,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
memcpy(&ha->plogi_els_payld.data, memcpy(&ha->plogi_els_payld.data,
(void *)ha->init_cb, (void *)ha->init_cb,
sizeof(ha->plogi_els_payld.data)); sizeof(ha->plogi_els_payld.data));
set_bit(RELOGIN_NEEDED, &vha->dpc_flags);
} else { } else {
ql_dbg(ql_dbg_init, vha, 0x00d1, ql_dbg(ql_dbg_init, vha, 0x00d1,
"PLOGI ELS param read fail.\n"); "PLOGI ELS param read fail.\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment