Commit e048a0b2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Oded Gabbay

amdkfd: fix an error handling bug in pqm_create_queue()

The call to kernel_queue_uninit(NULL) will trigger a BUG(), and also the
error code is incorrect.

Fixes: 45102048 ('amdkfd: Add process queue manager module')
Reviewed-by: default avatarOded Gabbay <oded.gabbay@amd.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@amd.com>
parent 66333cb3
...@@ -208,7 +208,7 @@ int pqm_create_queue(struct process_queue_manager *pqm, ...@@ -208,7 +208,7 @@ int pqm_create_queue(struct process_queue_manager *pqm,
case KFD_QUEUE_TYPE_DIQ: case KFD_QUEUE_TYPE_DIQ:
kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_DIQ); kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_DIQ);
if (kq == NULL) { if (kq == NULL) {
kernel_queue_uninit(kq); retval = -ENOMEM;
goto err_create_queue; goto err_create_queue;
} }
kq->queue->properties.queue_id = *qid; kq->queue->properties.queue_id = *qid;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment