Commit ef5201c8 authored by Xin Long's avatar Xin Long Committed by David S. Miller

bonding: remove rtmsg_ifinfo called after bond_lower_state_changed

After the patch 'rtnetlink: bring NETDEV_CHANGELOWERSTATE event
process back to rtnetlink_event', bond_lower_state_changed would
generate NETDEV_CHANGEUPPER event which would send a notification
to userspace in rtnetlink_event.

There's no need to call rtmsg_ifinfo to send the notification
any more. So this patch is to remove it from these places after
bond_lower_state_changed.

Besides, after this, rtmsg_ifinfo is not needed to be exported.
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent eeda3fb9
...@@ -330,7 +330,6 @@ static inline void bond_set_active_slave(struct slave *slave) ...@@ -330,7 +330,6 @@ static inline void bond_set_active_slave(struct slave *slave)
slave->backup = 0; slave->backup = 0;
bond_queue_slave_event(slave); bond_queue_slave_event(slave);
bond_lower_state_changed(slave); bond_lower_state_changed(slave);
rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_ATOMIC);
} }
} }
...@@ -340,7 +339,6 @@ static inline void bond_set_backup_slave(struct slave *slave) ...@@ -340,7 +339,6 @@ static inline void bond_set_backup_slave(struct slave *slave)
slave->backup = 1; slave->backup = 1;
bond_queue_slave_event(slave); bond_queue_slave_event(slave);
bond_lower_state_changed(slave); bond_lower_state_changed(slave);
rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_ATOMIC);
} }
} }
...@@ -353,7 +351,6 @@ static inline void bond_set_slave_state(struct slave *slave, ...@@ -353,7 +351,6 @@ static inline void bond_set_slave_state(struct slave *slave,
slave->backup = slave_state; slave->backup = slave_state;
if (notify) { if (notify) {
bond_lower_state_changed(slave); bond_lower_state_changed(slave);
rtmsg_ifinfo(RTM_NEWLINK, slave->dev, 0, GFP_ATOMIC);
bond_queue_slave_event(slave); bond_queue_slave_event(slave);
slave->should_notify = 0; slave->should_notify = 0;
} else { } else {
...@@ -385,7 +382,6 @@ static inline void bond_slave_state_notify(struct bonding *bond) ...@@ -385,7 +382,6 @@ static inline void bond_slave_state_notify(struct bonding *bond)
bond_for_each_slave(bond, tmp, iter) { bond_for_each_slave(bond, tmp, iter) {
if (tmp->should_notify) { if (tmp->should_notify) {
bond_lower_state_changed(tmp); bond_lower_state_changed(tmp);
rtmsg_ifinfo(RTM_NEWLINK, tmp->dev, 0, GFP_ATOMIC);
tmp->should_notify = 0; tmp->should_notify = 0;
} }
} }
......
...@@ -2989,7 +2989,6 @@ void rtmsg_ifinfo(int type, struct net_device *dev, unsigned int change, ...@@ -2989,7 +2989,6 @@ void rtmsg_ifinfo(int type, struct net_device *dev, unsigned int change,
{ {
rtmsg_ifinfo_event(type, dev, change, rtnl_get_event(0), flags, NULL); rtmsg_ifinfo_event(type, dev, change, rtnl_get_event(0), flags, NULL);
} }
EXPORT_SYMBOL(rtmsg_ifinfo);
void rtmsg_ifinfo_newnet(int type, struct net_device *dev, unsigned int change, void rtmsg_ifinfo_newnet(int type, struct net_device *dev, unsigned int change,
gfp_t flags, int *new_nsid) gfp_t flags, int *new_nsid)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment