Commit f367cc1e authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

[media] stk1160: unlock on error path stk1160_set_alternate()

There are some unlocks missing on error.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a7bd7756
......@@ -159,8 +159,9 @@ static bool stk1160_set_alternate(struct stk1160 *dev)
static int stk1160_start_streaming(struct stk1160 *dev)
{
int i, rc;
bool new_pkt_size;
int rc = 0;
int i;
/* Check device presence */
if (!dev->udev)
......@@ -183,7 +184,7 @@ static int stk1160_start_streaming(struct stk1160 *dev)
if (!dev->isoc_ctl.num_bufs || new_pkt_size) {
rc = stk1160_alloc_isoc(dev);
if (rc < 0)
return rc;
goto out_unlock;
}
/* submit urbs and enables IRQ */
......@@ -192,7 +193,7 @@ static int stk1160_start_streaming(struct stk1160 *dev)
if (rc) {
stk1160_err("cannot submit urb[%d] (%d)\n", i, rc);
stk1160_uninit_isoc(dev);
return rc;
goto out_unlock;
}
}
......@@ -205,9 +206,10 @@ static int stk1160_start_streaming(struct stk1160 *dev)
stk1160_dbg("streaming started\n");
out_unlock:
mutex_unlock(&dev->v4l_lock);
return 0;
return rc;
}
/* Must be called with v4l_lock hold */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment